Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pin version in links to external docs for [2/3] #19672

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 19, 2024

What does this PR do?

follow-up for #19584 applied for Fabric

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/conf.py, .github/workflows/docs-build.yml, requirements/docs.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/conf.py, .github/workflows/docs-build.yml, requirements/docs.txt.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success
docs-make (app, html) success

These checks are required after the changes to .github/workflows/docs-build.yml, requirements/docs.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested review from ethanwharris, justusschock and a team March 19, 2024 19:36
@Borda Borda requested review from lantiga and tchaton as code owners March 19, 2024 19:39
@github-actions github-actions bot added ci Continuous Integration dependencies Pull requests that update a dependency file labels Mar 19, 2024
requirements/docs.txt Outdated Show resolved Hide resolved
@Borda Borda requested a review from awaelchli March 20, 2024 06:25
@Borda
Copy link
Member Author

Borda commented Mar 22, 2024

@awaelchli lets merge this to resolve actually blocked update to the latest...

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a PR for the update?

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what I'm accepting

@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2024
@Borda Borda merged commit b9bfd1e into master Mar 25, 2024
35 checks passed
@Borda Borda deleted the docs/pin-version branch March 25, 2024 09:45
@awaelchli awaelchli added this to the 2.3 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants