Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing arguments in get_metrics() #19629

Merged
merged 1 commit into from
Mar 15, 2024
Merged

docs: fix missing arguments in get_metrics() #19629

merged 1 commit into from
Mar 15, 2024

Conversation

invisprints
Copy link
Contributor

@invisprints invisprints commented Mar 14, 2024

What does this PR do?

Fix missing arguments in get_metrics(), otherwise it will raise TypeError: get_metrics() missing 2 required positional arguments: 'trainer' and 'pl_module'

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19629.org.readthedocs.build/en/19629/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Mar 14, 2024
@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2024
@awaelchli awaelchli merged commit 7555384 into Lightning-AI:master Mar 15, 2024
22 of 23 checks passed
@awaelchli awaelchli added this to the 2.3 milestone Mar 15, 2024
@awaelchli awaelchli added the community This PR is from the community label Mar 15, 2024
@invisprints invisprints deleted the patch-1 branch March 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants