-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support consolidating sharded checkpoints with the fabric
CLI
#19560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
feature/fabric-run-consolidate
branch
from
March 3, 2024 01:17
97150a7
to
0125c34
Compare
awaelchli
added
feature
Is an improvement or enhancement
strategy: fsdp
Fully Sharded Data Parallel
fun
Staff contributions outside working hours - to differentiate from the "community" label
labels
Mar 3, 2024
for more information, see https://pre-commit.ci
awaelchli
requested review from
carmocca,
justusschock,
lantiga and
Borda
as code owners
March 3, 2024 01:20
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19560 +/- ##
=========================================
- Coverage 84% 58% -25%
=========================================
Files 424 419 -5
Lines 34910 34823 -87
=========================================
- Hits 29263 20371 -8892
- Misses 5647 14452 +8805 |
carmocca
approved these changes
Mar 3, 2024
Borda
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before (hard to remember):
Now:
📚 Documentation preview 📚: https://pytorch-lightning--19560.org.readthedocs.build/en/19560/
cc @Borda @carmocca @justusschock @awaelchli