Rename fabric run model to fabric run
#19527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
lantiga,
Borda and
tchaton
as code owners
github-actions
bot
added
docs
github-actions
bot
added
the
app (removed)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19527 +/- ##
=========================================
- Coverage 84% 76% -7%
=========================================
Files 450 450
Lines 38266 38259 -7
=========================================
- Hits 31998 29180 -2818
- Misses 6268 9079 +2811 |
carmocca
approved these changes
Feb 25, 2024
awaelchli
added
the
fun
Borda
approved these changes
Feb 25, 2024
justusschock
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The command
lightning run modelwas recently renamed because thelightningentry point was removed from the package and repurposed (#19442). Now that commands from app are no longer bundled under therunsubcommand, the extrarun modelsubcommand level is no longer necessary. Since #19442 already made a breaking change, we take this opportunity to make this simplification at the same time. This was discussed with @lantiga.This PR also updates a few references in docs and examples that were missed in #19442.
📚 Documentation preview 📚: https://pytorch-lightning--19527.org.readthedocs.build/en/19527/
cc @Borda @justusschock @carmocca @awaelchli