Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSVLogger(name: ...) optional str #19518

Merged

Conversation

mwip
Copy link
Contributor

@mwip mwip commented Feb 23, 2024

This patch adds Optional typing to the name parameter in CSVLogger reflecting the actual behavior. This increases coherence with other loggers and helps with type checking. Additionally documentation is improved.

This patch does NOT change the underlying behavior. Hence no additional tests were added. Tests already can be found in
tests/tests_pytorch/loggers/test_csv.py#L85-L90

Closes #19433

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19518.org.readthedocs.build/en/19518/

This patch adds `Optional` typing to the `name` parameter in `CSVLogger`
reflecting the actual behavior. This increases coherence with other
loggers and helps with type checking. Additionally documentation is
improved.

This patch does NOT change the underlying behavior. Hence no additional
tests were added. Tests already can be found in
tests/tests_pytorch/loggers/test_csv.py#L85-L90

Closes Lightning-AI#19433
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 23, 2024
@awaelchli awaelchli added docs Documentation related code quality labels Feb 23, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 23, 2024
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 23, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #19518 (6c9ab82) into master (a41528c) will decrease coverage by 29%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19518      +/-   ##
==========================================
- Coverage      82%      53%     -29%     
==========================================
  Files         450      445       -5     
  Lines       38253    38155      -98     
==========================================
- Hits        31454    20350   -11104     
- Misses       6799    17805   +11006     

@mergify mergify bot added the ready PRs ready to be merged label Feb 23, 2024
@awaelchli awaelchli added the community This PR is from the community label Feb 23, 2024
@awaelchli awaelchli merged commit 0235543 into Lightning-AI:master Feb 23, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing: make CSVLogger name optional str
3 participants