-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CSVLogger(name: ...)
optional str
#19518
Merged
awaelchli
merged 3 commits into
Lightning-AI:master
from
mwip:19433_typing_optional_str_in_csv_logger
Feb 23, 2024
Merged
Make CSVLogger(name: ...)
optional str
#19518
awaelchli
merged 3 commits into
Lightning-AI:master
from
mwip:19433_typing_optional_str_in_csv_logger
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds `Optional` typing to the `name` parameter in `CSVLogger` reflecting the actual behavior. This increases coherence with other loggers and helps with type checking. Additionally documentation is improved. This patch does NOT change the underlying behavior. Hence no additional tests were added. Tests already can be found in tests/tests_pytorch/loggers/test_csv.py#L85-L90 Closes Lightning-AI#19433
mwip
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
February 23, 2024 10:17
awaelchli
reviewed
Feb 23, 2024
awaelchli
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19518 +/- ##
==========================================
- Coverage 82% 53% -29%
==========================================
Files 450 445 -5
Lines 38253 38155 -98
==========================================
- Hits 31454 20350 -11104
- Misses 6799 17805 +11006 |
carmocca
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
Optional
typing to thename
parameter inCSVLogger
reflecting the actual behavior. This increases coherence with other loggers and helps with type checking. Additionally documentation is improved.This patch does NOT change the underlying behavior. Hence no additional tests were added. Tests already can be found in
tests/tests_pytorch/loggers/test_csv.py#L85-L90
Closes #19433
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19518.org.readthedocs.build/en/19518/