Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning App: Use the batch get endpoint #19180

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Lightning App: Use the batch get endpoint #19180

merged 13 commits into from
Dec 18, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 18, 2023 •
edited by github-actions bot
Loading

What does this PR do?

This PR improves the speed at which deltas are consumed on the LightningAI platform.

It roughly takes 1 min locally to get all deltas required in other to start a multi node job for 64 CPU.

Screenshot 2023-12-18 at 18 00 55

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19180.org.readthedocs.build/en/19180/

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Dec 18, 2023
@tchaton tchaton marked this pull request as ready for review December 18, 2023 18:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (macOS-12, app, 3.11, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (ubuntu-22.04, app, 3.11, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.11, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/testing/helpers.py, src/lightning/app/utilities/packaging/lightning_utils.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_queues.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/testing/helpers.py, src/lightning/app/utilities/packaging/lightning_utils.py.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success ✅
docs-make (app, html) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/testing/helpers.py, src/lightning/app/utilities/packaging/lightning_utils.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/testing/helpers.py, src/lightning/app/utilities/packaging/lightning_utils.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/testing/helpers.py, src/lightning/app/utilities/packaging/lightning_utils.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Dec 18, 2023
@tchaton tchaton merged commit ecdfab0 into master Dec 18, 2023
81 checks passed
@tchaton tchaton deleted the use_get_all branch December 18, 2023 20:22
Borda pushed a commit that referenced this pull request Dec 19, 2023
@tchaton @Borda
Lightning App: Use the batch get endpoint (#19180)
6b54e63 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: thomas <[email protected]>
(cherry picked from commit ecdfab0)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
@tchaton @lantiga
Lightning App: Use the batch get endpoint (#19180)
3dd26d2 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: thomas <[email protected]>
(cherry picked from commit ecdfab0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@rusenask rusenask rusenask approved these changes

@lantiga lantiga lantiga approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @lantiga @rusenask @ethanwharris