-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize loading time for chunks to be there #19109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
approved these changes
Dec 4, 2023
awaelchli
approved these changes
Dec 4, 2023
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Dec 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19109 +/- ##
==========================================
- Coverage 82% 51% -31%
==========================================
Files 443 437 -6
Lines 36716 36611 -105
==========================================
- Hits 30062 18542 -11520
- Misses 6654 18069 +11415 |
Borda
approved these changes
Dec 4, 2023
Borda
pushed a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: thomas <[email protected]> (cherry picked from commit 35ea94f)
lantiga
pushed a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: thomas <[email protected]> (cherry picked from commit 35ea94f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
data (external)
litdata package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes a tiny optimisation to loading time. Right now, if the chunk was available, we would still wait 0.1 second for no reason.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19109.org.readthedocs.build/en/19109/
cc @Borda