Make ModelCheckpoint._format_checkpoint_name an instance method
#19054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
carmocca
approved these changes
Nov 22, 2023
awaelchli
added
the
fun
Borda
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18956
It is now possible to set
CHECKPOINT_JOIN_CHARandCHECKPOINT_EQUALS_CHARvia the instance, which is more intuitive. Setting it via the class is still possible.📚 Documentation preview 📚: https://pytorch-lightning--19054.org.readthedocs.build/en/19054/
cc @Borda @carmocca @awaelchli