Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fault tolerance Streaming Dataset 2/n #19052

Merged
merged 24 commits into from
Nov 23, 2023
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 22, 2023

What does this PR do?

This PR addresses the comments from @awaelchli on this PR: #19049

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19052.org.readthedocs.build/en/19052/

cc @Borda

@github-actions github-actions bot added the data (external) litdata package label Nov 22, 2023
Copy link
Contributor

github-actions bot commented Nov 22, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
data-cpu (windows-2022, lightning, 3.10, 2.1) success

These checks are required after the changes to src/lightning/data/streaming/cache.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/serializers.py, src/lightning/data/streaming/shuffle.py, tests/tests_data/streaming/test_dataset.py, tests/tests_data/streaming/test_reader.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/data/streaming/cache.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/serializers.py, src/lightning/data/streaming/shuffle.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/data/streaming/cache.py, src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/serializers.py, src/lightning/data/streaming/shuffle.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning/data/streaming/shuffle.py Outdated Show resolved Hide resolved
src/lightning/data/streaming/dataset.py Outdated Show resolved Hide resolved
src/lightning/data/streaming/dataset.py Outdated Show resolved Hide resolved
src/lightning/data/streaming/cache.py Outdated Show resolved Hide resolved
@tchaton tchaton requested a review from awaelchli November 23, 2023 13:08
@Borda Borda requested a review from lantiga November 23, 2023 17:12
@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2023
@tchaton tchaton merged commit a6da1e3 into master Nov 23, 2023
54 checks passed
@tchaton tchaton deleted the resumable_streaming_dataset_2 branch November 23, 2023 17:40
Borda pushed a commit that referenced this pull request Dec 19, 2023
Co-authored-by: thomas <[email protected]>
(cherry picked from commit a6da1e3)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
Co-authored-by: thomas <[email protected]>
(cherry picked from commit a6da1e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data (external) litdata package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants