Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numpy support for the StreamingDataset 1/2 #19050

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Add numpy support for the StreamingDataset 1/2 #19050

merged 4 commits into from
Nov 22, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 22, 2023 •
edited by github-actions bot
Loading

What does this PR do?

This PR adds the first piece for numpy support (the serializers). The next step would be to enable text support for numpy.

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19050.org.readthedocs.build/en/19050/

cc @Borda

@github-actions github-actions bot added the data (external) litdata package label Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success ✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
data-cpu (windows-2022, lightning, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/data/streaming/constants.py, src/lightning/data/streaming/serializers.py, tests/tests_data/streaming/test_serializer.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/data/streaming/constants.py, src/lightning/data/streaming/serializers.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/data/streaming/constants.py, src/lightning/data/streaming/serializers.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

lantiga
lantiga approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment related to efficiency

src/lightning/data/streaming/serializers.py Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 22, 2023
@tchaton tchaton merged commit 7eca9c1 into master Nov 22, 2023
55 checks passed
@tchaton tchaton deleted the add_numpy_support branch November 22, 2023 18:00
awaelchli
awaelchli reviewed Nov 22, 2023
View reviewed changes
tests/tests_data/streaming/test_serializer.py Show resolved Hide resolved
src/lightning/data/streaming/serializers.py Show resolved Hide resolved
src/lightning/data/streaming/serializers.py
Comment on lines +225 to +226
shape.append(np.frombuffer(data[8 + 4 * shape_idx : 8 + 4 * (shape_idx + 1)], np.uint32).item())
tensor = np.frombuffer(data[8 + 4 * (shape_idx + 1) : len(data)], dtype=dtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave comments when we hardcode the numbers

Borda pushed a commit that referenced this pull request Dec 19, 2023
@tchaton @Borda
Add numpy support for the StreamingDataset 1/2 (#19050)
6e2dc5e 
Co-authored-by: thomas <[email protected]>
(cherry picked from commit 7eca9c1)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
@tchaton @lantiga
Add numpy support for the StreamingDataset 1/2 (#19050)
04e9ad3 
Co-authored-by: thomas <[email protected]>
(cherry picked from commit 7eca9c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli left review comments

@lantiga lantiga lantiga approved these changes

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
data (external) litdata package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @lantiga @awaelchli @Borda