Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct s3 support to the streaming dataset #19044

Merged
merged 8 commits into from
Nov 22, 2023
+35 −23
Merged

Add direct s3 support to the streaming dataset #19044

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89f6562
update
Nov 21, 2023
96c3d45
update
Nov 21, 2023
b83dbe1
update
Nov 21, 2023
0d65210
update
Nov 21, 2023
e8f5610
update
Nov 21, 2023
4e37997
update
Nov 21, 2023
6ae9f33
update
Nov 21, 2023
8774f0f
Merge branch 'master' into add_s3_streaming_test
tchaton Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
thomas authored and thomas committed Nov 21, 2023
commit 0d6521033f7b7222c257c6816f039defbc7bd033
4 changes: 4 additions & 0 deletions .github/workflows/ci-tests-data.yml
View file
Original file line number Diff line number Diff line change
@@ -94,6 +94,10 @@ jobs:

- name: Testing Data
working-directory: tests/tests_data
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_PUB_ACCESS_KEY }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_PUB_SECRET_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
# NOTE: do not include coverage report here, see: https://github.com/nedbat/coveragepy/issues/1003
run: |
python -m coverage run --source lightning \