-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the LightningDataset relying on un-maintained torchdata #19019
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_data: CPU workflow
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Co-authored-by: thomas <[email protected]> (cherry picked from commit 792cb73)
Co-authored-by: thomas <[email protected]> (cherry picked from commit 792cb73)
What does this PR do?
This PR removes the LightningDataset in favor of the map, optimize, StreamingDataset. In the future, we can re-investigate not using chunks but this would come in a second phase.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19019.org.readthedocs.build/en/19019/
cc @Borda