Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Item Loader bugs #19017

Merged
merged 37 commits into from
Nov 16, 2023
Merged

Resolve Item Loader bugs #19017

merged 37 commits into from
Nov 16, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 16, 2023 •
edited by github-actions bot
Loading

What does this PR do?

This PR fixes some convergence issues with the TokensLoader and add more tests to ensure we avoid regression.

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19017.org.readthedocs.build/en/19017/

cc @carmocca @Borda

@github-actions github-actions bot added the data (external) litdata package label Nov 16, 2023
@tchaton tchaton marked this pull request as ready for review November 16, 2023 19:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_data: CPU workflow
Check ID Status
data-cpu (macOS-11, lightning, 3.10, 2.1) success ✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
data-cpu (windows-2022, lightning, 3.10, 2.1) success ✅

These checks are required after the changes to src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/functions.py, src/lightning/data/streaming/item_loader.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/shuffle.py, tests/tests_data/streaming/test_cache.py, tests/tests_data/streaming/test_dataset.py, tests/tests_data/streaming/test_reader.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/functions.py, src/lightning/data/streaming/item_loader.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/shuffle.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/data/streaming/dataset.py, src/lightning/data/streaming/functions.py, src/lightning/data/streaming/item_loader.py, src/lightning/data/streaming/reader.py, src/lightning/data/streaming/sampler.py, src/lightning/data/streaming/shuffle.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

awaelchli
awaelchli approved these changes Nov 16, 2023
View reviewed changes
src/lightning/data/streaming/dataset.py Show resolved Hide resolved
src/lightning/data/streaming/item_loader.py Show resolved Hide resolved
src/lightning/data/streaming/item_loader.py Outdated Show resolved Hide resolved
tests/tests_data/streaming/test_dataset.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2023
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 16, 2023
@github-actions github-actions bot added the ci Continuous Integration label Nov 16, 2023
@tchaton tchaton marked this pull request as draft November 16, 2023 21:43
@mergify mergify bot removed the ready PRs ready to be merged label Nov 16, 2023
@tchaton tchaton marked this pull request as ready for review November 16, 2023 22:04
@tchaton tchaton changed the title Resolve Item Loader bugs (WIP) Resolve Item Loader bugs Nov 16, 2023
@awaelchli awaelchli self-requested a review November 16, 2023 22:05
@github-actions github-actions bot removed ci Continuous Integration dependencies Pull requests that update a dependency file labels Nov 16, 2023
@tchaton tchaton changed the title (WIP) Resolve Item Loader bugs Resolve Item Loader bugs Nov 16, 2023
@tchaton tchaton merged commit 6e517bd into master Nov 16, 2023
54 checks passed
@tchaton tchaton deleted the resolve_items_loader_bug branch November 16, 2023 23:07
@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2023
Borda pushed a commit that referenced this pull request Dec 19, 2023
@tchaton @Borda
Resolve Item Loader bugs (#19017)
e94561f 
Co-authored-by: thomas <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 6e517bd)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
@tchaton @lantiga
Resolve Item Loader bugs (#19017)
c2660b1 
Co-authored-by: thomas <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 6e517bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@ethanwharris ethanwharris ethanwharris approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
data (external) litdata package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @awaelchli @ethanwharris @carmocca