Fix bitsandbytes layer conversion under init_module context manager
#18914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
approved these changes
Nov 1, 2023
|
I think the docker image. We could put it in |
github-actions
bot
added
ci
awaelchli
changed the title
init_module context managerinit_module context manager
awaelchli
requested review from
justusschock,
Borda,
ethanwharris,
lantiga and
tchaton
as code owners
github-actions
bot
added
pl
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18914 +/- ##
==========================================
- Coverage 75% 27% -49%
==========================================
Files 448 440 -8
Lines 35910 35758 -152
==========================================
- Hits 27066 9569 -17497
- Misses 8844 26189 +17345 |
awaelchli
changed the title
init_module context managerinit_module context manager
|
The docker build passed, I pushed the image to the hub, re-triggered the GPU CI and the test passes now! |
Borda
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18913
This test fails on master, but didn't run in our CI because GPU CI does not install bitsandbytes:
https://github.com/Lightning-AI/lightning/blob/7a5b7f5561b34f13da1e0aa26af18b94b62494cc/tests/tests_fabric/plugins/precision/test_bitsandbytes.py#L102
This PR adds the missing installation. Now the test passes:
https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=180654&view=logs&j=3f274fac-2e11-54ca-487e-194c91f3ae9f
📚 Documentation preview 📚: https://pytorch-lightning--18914.org.readthedocs.build/en/18914/
cc @carmocca @Borda @justusschock @awaelchli