-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModelCheckpoint
callback for no loggers case
#18867
Fix ModelCheckpoint
callback for no loggers case
#18867
Conversation
I've made a minimal quick fix - probably the most appropriate will be to make a setter and a getter for the Whatever you prefer but also it could be in a different, follow up PR. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18867 +/- ##
=========================================
- Coverage 75% 48% -27%
=========================================
Files 443 435 -8
Lines 35448 35296 -152
=========================================
- Hits 26718 16926 -9792
- Misses 8730 18370 +9640 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue description makes sense! Also to make this a setter in a follow-up. Thank you!
(cherry picked from commit 4d030c4)
(cherry picked from commit 4d030c4)
(cherry picked from commit 4d030c4)
What does this PR do?
Fixes #18865
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18867.org.readthedocs.build/en/18867/