Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelCheckpoint callback for no loggers case #18867

Conversation

ioangatop
Copy link
Contributor

@ioangatop ioangatop commented Oct 25, 2023

What does this PR do?

Fixes #18865

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18867.org.readthedocs.build/en/18867/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2023
@ioangatop
Copy link
Contributor Author

ioangatop commented Oct 25, 2023

I've made a minimal quick fix - probably the most appropriate will be to make a setter and a getter for the self.logdir.

Whatever you prefer but also it could be in a different, follow up PR.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #18867 (2157272) into master (0843041) will decrease coverage by 27%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #18867     +/-   ##
=========================================
- Coverage      75%      48%    -27%     
=========================================
  Files         443      435      -8     
  Lines       35448    35296    -152     
=========================================
- Hits        26718    16926   -9792     
- Misses       8730    18370   +9640     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue description makes sense! Also to make this a setter in a follow-up. Thank you!

@carmocca carmocca added bug Something isn't working callback: model checkpoint labels Oct 25, 2023
@carmocca carmocca added this to the 2.1.x milestone Oct 25, 2023
@carmocca carmocca added the community This PR is from the community label Oct 25, 2023
@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2023
@awaelchli awaelchli merged commit 4d030c4 into Lightning-AI:master Oct 27, 2023
90 of 91 checks passed
Borda pushed a commit that referenced this pull request Nov 2, 2023
Borda pushed a commit that referenced this pull request Nov 2, 2023
lantiga pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback: model checkpoint community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback ModelCheckpoint option save_last without logger fails on remote FS
4 participants