-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinghtningCLI now will not allow setting a class instance as a default #18822
LinghtningCLI now will not allow setting a class instance as a default #18822
Conversation
6caf334
to
ef8bdf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mauvilsa, this is great!
ef8bdf8
to
9b08fff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18822 +/- ##
==========================================
- Coverage 83% 48% -35%
==========================================
Files 442 434 -8
Lines 35109 35017 -92
==========================================
- Hits 29173 16880 -12293
- Misses 5936 18137 +12201 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What does this PR do?
Fixes #18731
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18822.org.readthedocs.build/en/18822/