Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing lightning cli entry point #18821

Merged
merged 19 commits into from
Oct 25, 2023
Merged

Fix failing lightning cli entry point #18821

merged 19 commits into from
Oct 25, 2023

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 18, 2023 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Oct 18, 2023
@awaelchli awaelchli marked this pull request as ready for review October 18, 2023 23:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning/__setup__.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.12, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.12, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success ✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success ✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success ✅

These checks are required after the changes to tests/tests_fabric/test_cli.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning/__setup__.py, tests/tests_fabric/test_cli.py.

🟢 lightning: Store
Check ID Status
store-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
store-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success ✅
store-cpu (windows-2022, lightning, 3.10, 2.0) success ✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning/__setup__.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning/__setup__.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.11) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.11) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.11) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.11) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.11) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.11) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to src/lightning/__init__.py, src/lightning/__setup__.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli added this to the 2.1.x milestone Oct 18, 2023
@awaelchli awaelchli added the app (removed) Generic label for Lightning App package label Oct 18, 2023
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Oct 19, 2023
@awaelchli awaelchli added the bug Something isn't working label Oct 19, 2023
carmocca
carmocca reviewed Oct 19, 2023
View reviewed changes
src/lightning/__init__.py Outdated Show resolved Hide resolved
src/lightning/__setup__.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #18821 (548346a) into master (3f86ad7) will decrease coverage by 50%.
Report is 2 commits behind head on master.
The diff coverage is 25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18821      +/-   ##
==========================================
- Coverage      84%      33%     -50%     
==========================================
  Files         441      434       -7     
  Lines       34997    35012      +15     
==========================================
- Hits        29244    11607   -17637     
- Misses       5753    23405   +17652

@awaelchli awaelchli requested a review from carmocca October 23, 2023 14:40
@mergify mergify bot added the ready PRs ready to be merged label Oct 23, 2023
@awaelchli awaelchli merged commit 9e75bc9 into master Oct 25, 2023
93 checks passed
@awaelchli awaelchli deleted the bugfix/entry-point branch October 25, 2023 00:51
tsenst pushed a commit to tsenst/lightning that referenced this pull request Oct 26, 2023
@awaelchli @pre-commit-ci
@Borda @tsenst
Fix failing lightning cli entry point (Lightning-AI#18821)
8c4f904 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Borda pushed a commit that referenced this pull request Nov 2, 2023
@awaelchli @Borda
Fix failing lightning cli entry point (#18821)
f3cbb13 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 9e75bc9)
Borda pushed a commit that referenced this pull request Nov 2, 2023
@awaelchli @Borda
Fix failing lightning cli entry point (#18821)
697c6c3 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 9e75bc9)
lantiga pushed a commit that referenced this pull request Nov 6, 2023
@awaelchli @lantiga
Fix failing lightning cli entry point (#18821)
fba8bf3 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 9e75bc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Milestone
2.1.x
Development

Successfully merging this pull request may close these issues.

lightning run cli entry point stopped working after dropping app from top level
4 participants
@awaelchli @Borda @ethanwharris @carmocca