Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop starsessions from App's requirements #18470

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2023

Updates the requirements on starsessions to permit the latest version.

Release notes

Sourced from starsessions's releases.

v2.1.2

What's Changed

Full Changelog: alex-oleshkevich/starsessions@v2.1.1...v2.1.2

Commits
  • 12914cc minor updates
  • 11bd0bc Merge pull request #62 from alex-oleshkevich/improve-coverage
  • 9d0c201 improve code coverage where possible
  • 9cc7310 improve test coverage
  • aa8d432 Merge pull request #61 from alex-oleshkevich/timedelta-support
  • 8534b6a update pre-commit config
  • 8870f28 allow datetime.timedelta as lifetime value
  • 564314c update deps
  • 0023981 modernize pyproject
  • 074b0e6 fix isort issues
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

📚 Documentation preview 📚: https://pytorch-lightning--18470.org.readthedocs.build/en/18470/

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

cc @Borda

Updates the requirements on [starsessions](https://github.com/alex-oleshkevich/starsessions) to permit the latest version.
- [Release notes](https://github.com/alex-oleshkevich/starsessions/releases)
- [Commits](alex-oleshkevich/starsessions@v1.2.1...v2.1.2)

---
updated-dependencies:
- dependency-name: starsessions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the ci Continuous Integration label Sep 4, 2023
@dependabot dependabot bot requested a review from a team September 4, 2023 01:30
@github-actions github-actions bot added app (removed) Generic label for Lightning App package and removed ci Continuous Integration labels Sep 4, 2023
requirements/app/app.txt Outdated Show resolved Hide resolved
@Borda Borda changed the title Update starsessions requirement from <2.0,>=1.2.1 to >=1.2.1,<3.0 in /requirements Update starsessions requirement from <2.0,>=1.2.1 to >=1.2.1,<2.1.0 in /requirements Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) success
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (macOS-12, app, 3.11, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (ubuntu-22.04, app, 3.11, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.11, latest) success

These checks are required after the changes to src/lightning/app/core/api.py, src/lightning/app/utilities/imports.py, requirements/app/app.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to src/lightning/app/core/api.py, src/lightning/app/utilities/imports.py, requirements/app/app.txt.

🟢 lightning_app: Docs
Check ID Status
docs-make (app, doctest) success
docs-make (app, html) success

These checks are required after the changes to src/lightning/app/core/api.py, src/lightning/app/utilities/imports.py, requirements/app/app.txt.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/app/app.txt, src/lightning/app/core/api.py, src/lightning/app/utilities/imports.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/app/core/api.py, src/lightning/app/utilities/imports.py, requirements/app/app.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2023

A newer version of starsessions exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Borda
Copy link
Member

Borda commented Oct 2, 2023

seem we would need to freeze until this is resolved 🤔

@mergify mergify bot added the has conflicts label Oct 4, 2023
@Borda Borda marked this pull request as draft October 4, 2023 19:26
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 12, 2023
@Borda Borda marked this pull request as ready for review December 12, 2023 20:13
@mergify mergify bot removed the has conflicts label Dec 12, 2023
@Borda Borda self-assigned this Dec 12, 2023
@dependabot dependabot bot requested a review from ethanwharris as a code owner December 12, 2023 21:14
@Borda Borda changed the title Update starsessions requirement from <2.0,>=1.2.1 to >=1.2.1,<2.1.0 in /requirements Drop starsessions from App's requirements Dec 12, 2023
@Borda
Copy link
Member

Borda commented Dec 12, 2023

There were breaking changes without proper documentation in the release notes...
why do we need to rely on such package with 80 starts, it was also optional pkg 🦩

@mergify mergify bot added the ready PRs ready to be merged label Dec 13, 2023
@Borda Borda merged commit 369b990 into master Dec 13, 2023
83 checks passed
@Borda Borda deleted the dependabot-pip-requirements-starsessions-gte-1.2.1-and-lt-3.0 branch December 13, 2023 18:36
Borda pushed a commit that referenced this pull request Dec 19, 2023
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 369b990)
lantiga pushed a commit that referenced this pull request Dec 20, 2023
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 369b990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package dependencies Pull requests that update a dependency file ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants