Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage results for ReST doctests #1837

Closed
wants to merge 12 commits into from
Closed

Add coverage results for ReST doctests #1837

wants to merge 12 commits into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 14, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

An attempt to make the doctests show up in coverage report.
Follows #1511

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli marked this pull request as draft May 14, 2020 14:27
@mergify mergify bot requested a review from a team May 14, 2020 14:27
@awaelchli awaelchli changed the title [wip] Add overage results for ReST doctests [wip] Add coverage results for ReST doctests May 14, 2020
@awaelchli awaelchli added docs Documentation related ci Continuous Integration labels May 14, 2020
@awaelchli awaelchli changed the title [wip] Add coverage results for ReST doctests Add coverage results for ReST doctests May 14, 2020
@awaelchli awaelchli marked this pull request as ready for review May 14, 2020 17:20
@awaelchli awaelchli marked this pull request as draft May 14, 2020 17:30
@awaelchli awaelchli closed this May 16, 2020
@Borda Borda deleted the docs/rst-doctest-coverage branch May 28, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda will be requested when the pull request is marked ready for review Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@awaelchli