-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor path to root preventing circular import #18357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
tchaton,
lantiga,
awaelchli and
ethanwharris
as code owners
August 21, 2023 10:28
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 21, 2023
Borda
added
bug
Something isn't working
refactor
priority: 1
Medium priority task
and removed
app (removed)
Generic label for Lightning App package
labels
Aug 21, 2023
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 21, 2023
carmocca
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how these changes fix the problem?
because it imports something you do not need |
for more information, see https://pre-commit.ci
ethanwharris
approved these changes
Aug 21, 2023
awaelchli
approved these changes
Aug 21, 2023
Borda
added a commit
that referenced
this pull request
Aug 28, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit fbdbe63)
Borda
added a commit
that referenced
this pull request
Aug 28, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit fbdbe63)
Borda
added a commit
that referenced
this pull request
Aug 28, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit fbdbe63)
lantiga
pushed a commit
that referenced
this pull request
Aug 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit fbdbe63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
bug
Something isn't working
ci
Continuous Integration
priority: 1
Medium priority task
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addressing potential issue in Lightning-AI/torchmetrics#1886
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @justusschock @awaelchli @tchaton