Skip to content

Minor miscellaneous fixes #18077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lantiga merged 8 commits into from
Jul 20, 2023
Merged

Minor miscellaneous fixes #18077

lantiga merged 8 commits into from
Jul 20, 2023

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 14, 2023 •
edited by github-actions bot
Loading

What does this PR do?

See comments

cc @carmocca @Borda @justusschock @awaelchli

@carmocca carmocca added ci Continuous Integration tests labels Jul 14, 2023
@carmocca carmocca added this to the 2.1 milestone Jul 14, 2023
@carmocca carmocca self-assigned this Jul 14, 2023
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jul 14, 2023
carmocca
carmocca commented Jul 14, 2023
View reviewed changes
@carmocca carmocca marked this pull request as ready for review July 14, 2023 03:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.0) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, src/lightning/fabric/accelerators/cuda.py, requirements/pytorch/base.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/base.txt, tests/tests_pytorch/conftest.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, requirements/fabric/base.txt, src/lightning/fabric/accelerators/cuda.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success ✅

These checks are required after the changes to .azure/gpu-benchmarks.yml, requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/cuda.py.

🟡 pytorch-lightning: TPU workflow
Check ID Status
test-on-tpus (pytorch, xrt) no_status ❓
test-on-tpus (pytorch, pjrt) no_status ❓

These checks are required after the changes to .github/workflows/tpu-tests.yml.

🟢 fabric: Docs
Check ID Status
make-doctest (fabric) success ✅
make-html (fabric) success ✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, requirements/fabric/base.txt.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.11, 11.3.1) success ✅
build-cuda (3.9, 1.12, 11.7.1) success ✅
build-cuda (3.9, 1.13, 12.0.1) success ✅
build-cuda (3.10, 2.0, 12.0.1) success ✅
build-cuda (3.10, 2.0, 11.7.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.7.1) success ✅
build-pl (3.9, 1.13, 12.0.1) success ✅
build-pl (3.10, 2.0, 12.0.1) success ✅

These checks are required after the changes to .github/workflows/ci-dockers.yml, requirements/pytorch/base.txt, requirements/fabric/base.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/cuda.py, tests/tests_fabric/strategies/test_fsdp_integration.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to .azure/gpu-tests-fabric.yml, requirements/fabric/base.txt, src/lightning/fabric/accelerators/cuda.py, tests/tests_fabric/strategies/test_fsdp_integration.py.

🟡 lightning_fabric: TPU workflow
Check ID Status
test-on-tpus (fabric, xrt) no_status ❓
test-on-tpus (pytorch, pjrt) no_status ❓

These checks are required after the changes to .github/workflows/tpu-tests.yml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/cuda.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, requirements/fabric/base.txt, requirements/pytorch/base.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca changed the title Various miscellaneous fixes Minor miscellaneous fixes Jul 14, 2023
carmocca
carmocca commented Jul 14, 2023
View reviewed changes
Borda
Borda requested changes Jul 14, 2023
View reviewed changes
@carmocca carmocca requested a review from Borda July 14, 2023 13:08
@carmocca
Copy link
Contributor Author

carmocca commented Jul 18, 2023

@Borda can you review this again please?

@mergify mergify bot added the ready to be merged PRs ready to be merged label Jul 19, 2023
lantiga
lantiga approved these changes Jul 20, 2023
View reviewed changes
src/lightning/fabric/accelerators/cuda.py

def _clear_cuda_memory() -> None:
if _TORCH_GREATER_EQUAL_2_0:
# strangely, the attribute function be undefined when torch.compile is used
Copy link
Collaborator

@lantiga lantiga Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verb is missing "function [...] be undefined"

@lantiga lantiga merged commit 01b82e4 into master Jul 20, 2023
@lantiga lantiga deleted the carmocca/various-misc-fixes branch July 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga lantiga approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready to be merged PRs ready to be merged tests

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @lantiga @awaelchli @Borda