-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exponential backoff to HTTPQueue put #18013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
changed the title
Add backoff to queue put
Add exponential backoff to HTTPQueue put
Jul 7, 2023
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Jul 7, 2023
lantiga
requested review from
tchaton,
awaelchli,
ethanwharris and
Borda
as code owners
July 7, 2023 07:50
ethanwharris
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
awaelchli
approved these changes
Jul 7, 2023
Borda
approved these changes
Jul 7, 2023
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit bb47517)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit bb47517)
lantiga
added a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit bb47517)
weiji14
added a commit
to regro-cf-autotick-bot/lightning-feedstock
that referenced
this pull request
Jul 17, 2023
weiji14
added a commit
to conda-forge/lightning-feedstock
that referenced
this pull request
Jul 17, 2023
* updated v2.0.5 * Update pins for croniter, pydantic, websockets Xref https://github.com/Lightning-AI/lightning/blame/2.0.5/requirements/app/base.txt * Add backoff Xref Lightning-AI/pytorch-lightning#18013 --------- Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds exponential backoff to posts to the HTTP queue, for added resiliency on the works.
The PR introduces https://github.com/litl/backoff as a dependency.
In general, I think we need to encourage developers to take backoff strategies into account whenever they consume APIs.
Although the
backoff
package has been released 8 months ago, so it's not moving fast, it is quite ideal for our purposes.It's very minimal. Not a lot of code and we can easily fix it ourselves. No transitive dependencies.
It has a clean design:
So given the low risk and the high convenience, I recommend adding this dependency to our package.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda