Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: added map_location as an argument for the cls load_from_checkpoint #17950

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Fix: added map_location as an argument for the cls load_from_checkpoint #17950

merged 12 commits into from
Jul 3, 2023

Conversation

rjarun8
Copy link
Contributor

@rjarun8 rjarun8 commented Jun 29, 2023 •
edited by awaelchli
Loading

What does this PR do?

This PR addresses a bug in the PyTorch Lightning codebase where the LightningDataModule.load_from_checkpoint method was not correctly handling the map_location argument. This was causing issues when trying to load a DataModule from a checkpoint that was saved on a GPU-enabled machine, but being loaded on a CPU-only machine.

Fixes #17945
Fixes #17895

Before submitting

  • Was this discussed/agreed via a GitHub issue? Yes, this was discussed in issue Impossible to load a DataModule on CPU when checkpointed with GPU available #17945.
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun? Yes, I had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 29, 2023
@Quantum1921

This comment was marked as off-topic.

Sign in to view
@awaelchli awaelchli added checkpointing Related to checkpointing community This PR is from the community labels Jun 30, 2023
@awaelchli awaelchli added the bug Something isn't working label Jun 30, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Jun 30, 2023
@awaelchli awaelchli requested a review from justusschock as a code owner July 1, 2023 00:50
@mergify mergify bot added the ready PRs ready to be merged label Jul 3, 2023
@awaelchli awaelchli enabled auto-merge (squash) July 3, 2023 12:29
@awaelchli awaelchli merged commit 1484116 into Lightning-AI:master Jul 3, 2023
Borda pushed a commit that referenced this pull request Jul 7, 2023
@Borda
Fix: added map_location as an argument for the cls load_from_checkpoi…
ee94b4b 
…nt (#17950)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 1484116)
Borda pushed a commit that referenced this pull request Jul 7, 2023
@Borda
Fix: added map_location as an argument for the cls load_from_checkpoi…
4d08c6c 
…nt (#17950)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 1484116)
Borda pushed a commit that referenced this pull request Jul 7, 2023
@Borda
Fix: added map_location as an argument for the cls load_from_checkpoi…
3d87008 
…nt (#17950)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 1484116)
Borda pushed a commit that referenced this pull request Jul 7, 2023
@Borda
Fix: added map_location as an argument for the cls load_from_checkpoi…
a31a9d8 
…nt (#17950)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 1484116)
lantiga pushed a commit that referenced this pull request Jul 10, 2023
@lantiga
Fix: added map_location as an argument for the cls load_from_checkpoi…
9265b33 
…nt (#17950)

Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 1484116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working checkpointing Related to checkpointing community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
5 participants
@rjarun8 @Quantum1921 @awaelchli @carmocca @rjarun8235