Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of exception.args in _augment_message() #17948

Merged

Conversation

schuhschuh
Copy link
Contributor

What does this PR do?

Fixes #17947

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 28, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Left a minor comment. Could you also extend the test case in tests/tests_pytorch/utilities/test_exceptions.py please? Ping me if you need help :)

src/lightning/pytorch/utilities/exceptions.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added bug Something isn't working community This PR is from the community labels Jun 29, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Jun 29, 2023
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2023 19:46
@mergify mergify bot added the ready PRs ready to be merged label Jun 29, 2023
@awaelchli awaelchli merged commit 28beb8a into Lightning-AI:master Jun 29, 2023
Borda pushed a commit that referenced this pull request Jul 7, 2023
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 28beb8a)
lantiga pushed a commit that referenced this pull request Jul 10, 2023
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 28beb8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytorch: exceptions._augment_message() raises itself an exception when args contains no strings
3 participants