New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rich import error in Google Colab #17156

Merged

awaelchli merged 7 commits into master from bugfix/colab-import

Mar 21, 2023

Contributor

awaelchli commented Mar 20, 2023 •

edited by github-actions bot

Loading

What does this PR do?

Fixes #17136

I verified that this works in a fresh Google Colab and installing from this branch.

!pip install git+https://github.com/Lightning-AI/lightning.git@bugfix/colab-import

import lightning  # no error

Note: This only hides the issue with a lazy availability check. The underlying package incompatibility needs to be resolved by Google Colab. The linked issue provides more context.

cc @Borda @tchaton


          rich

088e76e

github-actions bot added the pl label

awaelchli added priority: 0 bug labels

awaelchli added this to the 2.0.x milestone

fix

d97ab73

awaelchli force-pushed the bugfix/colab-import branch from f1da7ae to d97ab73 Compare

March 20, 2023 22:30


          Merge branch 'master' into bugfix/colab-import

62bed18

awaelchli marked this pull request as ready for review

March 20, 2023 22:31

awaelchli requested review from williamFalcon, carmocca and justusschock as code owners

March 20, 2023 22:31


          [pre-commit.ci] auto fixes from pre-commit.com hooks

644de14

for more information, see https://pre-commit.ci

Contributor

github-actions bot commented Mar 20, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/rich_model_summary.py, src/lightning/pytorch/utilities/imports.py.

🟢 link-check

Check ID	Status
check-md-links / markdown-link-check	success	✅

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

awaelchli self-assigned this

Borda approved these changes

View reviewed changes

carmocca approved these changes

View reviewed changes

src/lightning/pytorch/utilities/imports.py Outdated Show resolved Hide resolved

mergify bot added the ready label

carmocca and others added 3 commits

March 21, 2023 15:49


          Remove dupe

dcbaa6d


          Merge branch 'master' into bugfix/colab-import

35a375a


          mypy it makes no sense

9b79fe4

awaelchli enabled auto-merge (squash)

March 21, 2023 15:35

awaelchli merged commit 66e2111 into master

awaelchli deleted the bugfix/colab-import branch

March 21, 2023 16:31

carmocca added a commit that referenced this pull request


          Fix rich import error in Google Colab (#17156)

8d7271c

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

lantiga pushed a commit that referenced this pull request


          Fix rich import error in Google Colab (#17156)

39a1210

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

This was referenced Mar 30, 2023

Trainers tutorial fails without refresh microsoft/torchgeo#765

Closed

torchgeo install in google colab microsoft/torchgeo#1054

Closed

Borda pushed a commit that referenced this pull request


          Fix rich import error in Google Colab (#17156)

c099f20

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit 66e2111)

Borda pushed a commit that referenced this pull request


          Fix rich import error in Google Colab (#17156)

7dc61c6

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit 66e2111)

lantiga pushed a commit that referenced this pull request


          Fix rich import error in Google Colab (#17156)

447b110

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

(cherry picked from commit 66e2111)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carmocca carmocca approved these changes

Borda Borda approved these changes

williamFalcon Awaiting requested review from williamFalcon

justusschock Awaiting requested review from justusschock justusschock is a code owner

Labels

bug pl priority: 0 ready