New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HPU broadcast override to the HPU strategy file #17011

Merged

Borda merged 4 commits into master from carmocca/hpu-bcast-obj-list

Mar 10, 2023

Contributor

carmocca commented Mar 9, 2023 •

edited by github-actions bot

Loading

What does this PR do?

I'm auditing the PL API. This should be marked as protected as they are not meant to be public API

cc @justusschock @awaelchli @Borda @jerome-habana @carmocca

carmocca added 3 commits

March 9, 2023 04:11


          Move HPU broadcast override to the HPU strategy file

b10f0c6


          Move HPU broadcast override to the HPU strategy file

321bbc1


          CHANGELOG

543dd3f

carmocca added refactor breaking change strategy: hpu (external) pl labels

carmocca added this to the 2.0 milestone

carmocca requested review from williamFalcon, awaelchli and justusschock as code owners

March 9, 2023 03:16

carmocca self-assigned this

Contributor

github-actions bot commented Mar 9, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/pytorch/overrides/torch_distributed.py, src/lightning/pytorch/strategies/hpu_parallel.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.


          Device

1ba81eb

awaelchli approved these changes

View reviewed changes

Borda approved these changes

View reviewed changes

mergify bot added the ready label

Borda enabled auto-merge (squash)

March 9, 2023 23:46

Borda merged commit da6263a into master

Borda deleted the carmocca/hpu-bcast-obj-list branch

March 10, 2023 00:04

Borda pushed a commit that referenced this pull request


          Move HPU broadcast override to the HPU strategy file (#17011)

16f1c4e

(cherry picked from commit da6263a)

lantiga pushed a commit that referenced this pull request


          Move HPU broadcast override to the HPU strategy file (#17011)

10774ca

(cherry picked from commit da6263a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Borda Borda approved these changes

awaelchli awaelchli approved these changes

williamFalcon Awaiting requested review from williamFalcon

justusschock Awaiting requested review from justusschock justusschock is a code owner

Labels

breaking change pl ready refactor strategy: hpu (external)