Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mypy job to 1.1.1 #16974

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Update mypy job to 1.1.1 #16974

merged 4 commits into from
Mar 10, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 6, 2023 •
edited
Loading

@carmocca carmocca added ci Continuous Integration refactor pl Generic label for PyTorch Lightning package labels Mar 6, 2023
@carmocca carmocca added this to the 2.0 milestone Mar 6, 2023
@carmocca carmocca self-assigned this Mar 6, 2023
@github-actions github-actions bot added app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric and removed ci Continuous Integration labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py, src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py.

🟢 fabric: Docs
Check ID Status
make-doctest (fabric) success ✅
make-html (fabric) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.0, pre) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/typing.txt, src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/app/core/app.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/fabric/plugins/collectives/collective.py, src/lightning/fabric/plugins/collectives/torch_collective.py, src/lightning/fabric/utilities/device_dtype_mixin.py, src/lightning/fabric/utilities/types.py, src/lightning/pytorch/_graveyard/legacy_import_unpickler.py, src/lightning/pytorch/core/datamodule.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ipu.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/combined_loader.py, src/lightning/pytorch/utilities/compile.py, src/lightning/pytorch/utilities/data.py, requirements/typing.txt.

🟢 link-check
Check ID Status
markdown-link-check success ✅

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #16974 (5cdfcd7) into master (da6263a) will increase coverage by 0%.
The diff coverage is 98%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #16974    +/-   ##
========================================
  Coverage      82%      82%            
========================================
  Files         436      418    -18     
  Lines       31793    31535   -258     
========================================
- Hits        25961    25787   -174     
+ Misses       5832     5748    -84

awaelchli
awaelchli approved these changes Mar 6, 2023
View reviewed changes
src/lightning/pytorch/utilities/testing/_runif.py Outdated Show resolved Hide resolved
src/lightning/pytorch/core/module.py Outdated Show resolved Hide resolved
src/lightning/pytorch/serve/servable_module.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 6, 2023
@carmocca carmocca removed this from the 2.0 milestone Mar 7, 2023
@carmocca
Copy link
Contributor Author

carmocca commented Mar 7, 2023 •
edited
Loading

Blocking this until IPU testing is back up and running

edit: reverted the IPU changes to a separate PR

@carmocca carmocca marked this pull request as draft March 7, 2023 13:09
@mergify mergify bot removed the ready PRs ready to be merged label Mar 7, 2023
This was referenced Mar 8, 2023
Merged
Merged
@carmocca carmocca changed the title Update mypy job to 1.0.1 Update mypy job to 1.1.1 Mar 9, 2023
@carmocca carmocca force-pushed the carmocca/mypy-1.0 branch from 8ef7d34 to aea50ea Compare March 9, 2023 20:43
@carmocca carmocca marked this pull request as ready for review March 9, 2023 20:44
@mergify mergify bot added the ready PRs ready to be merged label Mar 9, 2023
@carmocca
Copy link
Contributor Author

carmocca commented Mar 9, 2023

This is now blocked by #16657 (comment)

@carmocca carmocca enabled auto-merge (squash) March 10, 2023 00:25
@carmocca carmocca merged commit 9583128 into master Mar 10, 2023
@carmocca carmocca deleted the carmocca/mypy-1.0 branch March 10, 2023 01:43
Borda pushed a commit that referenced this pull request Mar 31, 2023
@carmocca @Borda
Update mypy job to 1.1.1 (#16974)
b20da7f 
(cherry picked from commit 9583128)
Borda pushed a commit that referenced this pull request Mar 31, 2023
@carmocca @Borda
Update mypy job to 1.1.1 (#16974)
81e7af4 
(cherry picked from commit 9583128)
Borda pushed a commit that referenced this pull request Mar 31, 2023
@carmocca @Borda
Update mypy job to 1.1.1 (#16974)
cc474bd 
(cherry picked from commit 9583128)
Borda pushed a commit that referenced this pull request Mar 31, 2023
@carmocca @Borda
Update mypy job to 1.1.1 (#16974)
8f9ab85 
(cherry picked from commit 9583128)
lantiga pushed a commit that referenced this pull request Apr 3, 2023
@carmocca @lantiga
Update mypy job to 1.1.1 (#16974)
809d257 
(cherry picked from commit 9583128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@carmocca carmocca

Labels
app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @Borda @akihironitta