Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add colocation identifier #16796

Merged
merged 18 commits into from
Jun 28, 2023
Merged

add colocation identifier #16796

merged 18 commits into from
Jun 28, 2023

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Feb 17, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Expose colocation_group_id; this will allow users of the lightning platform to use high speed interconnects.
As this has a couple of moving pieces I'll circle back and add documentation once this feature works end to end in production.

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Feb 17, 2023
@nicolai86 nicolai86 marked this pull request as ready for review February 17, 2023 15:43
@nicolai86 nicolai86 changed the title add colocation identifier [app] add colocation identifier Feb 17, 2023
@nicolai86 nicolai86 changed the title [app] add colocation identifier add colocation identifier Feb 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/utilities/packaging/cloud_compute.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/structures/test_structures.py, tests/tests_app/utilities/test_load_app.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/utilities/packaging/cloud_compute.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/utilities/packaging/cloud_compute.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/utilities/packaging/cloud_compute.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/utilities/packaging/cloud_compute.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton
tchaton approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Maybe a test ;)

src/lightning/app/utilities/packaging/cloud_compute.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2023
@awaelchli
Copy link
Contributor

@nicolai86 Some tests need adjustment because of the new attribute in the state.

@awaelchli awaelchli added this to the v1.9.x milestone Feb 17, 2023
@Borda
Copy link
Member

Borda commented Mar 29, 2023

@awaelchli could you help here to finish it?

@Borda Borda modified the milestones: v1.9.x, 2.0.x Mar 29, 2023
@awaelchli
Copy link
Contributor

@nicolai86 Should this work be continued?

@lantiga
Copy link
Collaborator

lantiga commented May 5, 2023 •
edited
Loading

Yes we are going to need it as a general attribute, but let's align with the rest of the team before continuing.

@Borda Borda marked this pull request as draft May 5, 2023 07:02
@mergify mergify bot removed the ready PRs ready to be merged label May 5, 2023
@tchaton tchaton marked this pull request as ready for review June 28, 2023 04:35
@mergify mergify bot added the ready PRs ready to be merged label Jun 28, 2023
@tchaton tchaton enabled auto-merge (squash) June 28, 2023 09:27
@tchaton tchaton disabled auto-merge June 28, 2023 09:27
@tchaton tchaton enabled auto-merge (squash) June 28, 2023 10:42
@tchaton tchaton merged commit b9dd977 into master Jun 28, 2023
@tchaton tchaton deleted the feat/colocation branch June 28, 2023 10:58
Borda pushed a commit that referenced this pull request Jul 7, 2023
@nicolai86 @Borda
add colocation identifier (#16796)
6b99a50 
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas <[email protected]>
(cherry picked from commit b9dd977)
lantiga pushed a commit that referenced this pull request Jul 10, 2023
@nicolai86 @lantiga
add colocation identifier (#16796)
bf3a9f4 
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas <[email protected]>
(cherry picked from commit b9dd977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolai86 @awaelchli @Borda @lantiga @ethanwharris @tchaton @justusschock