Introduce new precision layout in fabric #16767
Conversation
justusschock
changed the title
justusschock
added
precision: double
justusschock
requested review from
awaelchli,
carmocca,
edenlightning,
lantiga and
Borda
as code owners
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure IPU
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to 🟢 link-check
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16767 +/- ##
=========================================
- Coverage 82% 59% -22%
=========================================
Files 441 416 -25
Lines 31654 31371 -283
=========================================
- Hits 25816 18595 -7221
- Misses 5838 12776 +6938 |
for more information, see https://pre-commit.ci
Co-authored-by: Adrian Wälchli <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
Introduces new precision arguments to fabric.
Also makes sure that plugins only need to support the new version and all conversions happen within the connector.
First part of #9956
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @justusschock @awaelchli