Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/hotfix: pypi releasing #16722

Merged
merged 7 commits into from
Feb 10, 2023
Merged

ci/hotfix: pypi releasing #16722

merged 7 commits into from
Feb 10, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 10, 2023

What does this PR do?

debugging and unblocking release
see: https://github.com/Lightning-AI/lightning/actions/runs/4145442482/jobs/7170436308

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@github-actions github-actions bot added the ci Continuous Integration label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #16722 (16fc948) into release/stable (16fc948) will not change coverage.
The diff coverage is n/a.

❗ Current head 16fc948 differs from pull request most recent head 0c666ac. Consider uploading reports for the commit 0c666ac to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release/stable   #16722   +/-   ##
===============================================
  Coverage              82%      82%           
===============================================
  Files                 473      473           
  Lines               35080    35080           
===============================================
  Hits                28635    28635           
  Misses               6445     6445           

@Borda Borda marked this pull request as ready for review February 10, 2023 16:44
@Borda Borda requested review from awaelchli, justusschock and a team February 10, 2023 16:44
@github-actions
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 10, 2023
@Borda Borda changed the title fix pypi releasing ci/hotfix: pypi releasing Feb 10, 2023
@Borda Borda requested a review from a team February 10, 2023 16:54
@Borda Borda merged commit c24b4bb into release/stable Feb 10, 2023
@Borda Borda deleted the ci/pypi branch February 10, 2023 16:55
Borda added a commit that referenced this pull request Feb 10, 2023
@Borda Borda mentioned this pull request Feb 10, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants