New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Better lightning connect #16700

Merged

hhsecond merged 9 commits into master from byom

Feb 9, 2023

Contributor

hhsecond commented Feb 9, 2023 •

edited

Loading

What does this PR do?

Making lightning connect feature full

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified


          node-commands

a0216ce

hhsecond requested review from tchaton, lantiga, awaelchli and ethanwharris as code owners

February 9, 2023 11:35

github-actions bot added the app (removed) label

hhsecond self-assigned this

Contributor

github-actions bot commented Feb 9, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py, tests/tests_app/cli/test_connect_data.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/cli/connect/node.py, src/lightning/app/cli/lightning_cli.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.


          [pre-commit.ci] auto fixes from pre-commit.com hooks

a36dd96

for more information, see https://pre-commit.ci

hhsecond changed the title ~~[BYOM] Connect and Disconnect node~~ [App] Connect and Disconnect node

hhsecond added this to the future milestone

tchaton reviewed

View reviewed changes

src/lightning/app/cli/lightning_cli.py Outdated Show resolved Hide resolved

src/lightning/app/cli/connect/node.py Show resolved Hide resolved

src/lightning/app/cli/connect/node.py Show resolved Hide resolved

src/lightning/app/cli/connect/node.py Show resolved Hide resolved

ethanwharris reviewed

View reviewed changes

Member

ethanwharris left a comment

Looks good, might be good to have some tests at least for error cases

src/lightning/app/cli/connect/node.py Show resolved Hide resolved

src/lightning/app/cli/connect/node.py Outdated Show resolved Hide resolved

Sherin Thomas and others added 4 commits

February 9, 2023 18:15


          Merge branch 'master' into byom

1ad6754


          error checks

885f989


          merge

1a93ea7


          [pre-commit.ci] auto fixes from pre-commit.com hooks

33f003b

for more information, see https://pre-commit.ci

ethanwharris approved these changes

View reviewed changes

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM !

mergify bot added the ready label

thomas and others added 2 commits

February 9, 2023 13:03


          update

20da645


          precommit

ad62da7

hhsecond changed the title ~~[App] Connect and Disconnect node~~ [DO NOT MERGE][App] Connect and Disconnect node


          mypy

08562a9

hhsecond changed the title ~~[DO NOT MERGE][App] Connect and Disconnect node~~ [App] Connect and Disconnect node

hhsecond merged commit 44557b9 into master

hhsecond deleted the byom branch

February 9, 2023 13:51

hhsecond changed the title ~~[App] Connect and Disconnect node~~ [App] Better lightning connect

Borda pushed a commit that referenced this pull request


          [App] Connect and Disconnect node (#16700)

cea51f7

Connect and Disconnect node

(cherry picked from commit 44557b9)

Borda pushed a commit that referenced this pull request


          [App] Connect and Disconnect node (#16700)

6d92d7b

Connect and Disconnect node

(cherry picked from commit 44557b9)

Borda pushed a commit that referenced this pull request


          [App] Connect and Disconnect node (#16700)

cf0196c

Connect and Disconnect node

(cherry picked from commit 44557b9)

lantiga pushed a commit that referenced this pull request


          [App] Connect and Disconnect node (#16700)

22f49e6

Connect and Disconnect node

(cherry picked from commit 44557b9)

carmocca modified the milestones: future, v1.9.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) ready