-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename docs/source-app & adjust docs links for lightning #16676
Conversation
⛈️ Required checks status: Has failure 🔴
Groups summary🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟡 lightning_app: Tests workflow
These checks are required after the changes to 🔴 lightning_app: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
docs/source/levels/intermediate/run_lightning_work_in_parallel.rst
Outdated
Show resolved
Hide resolved
docs/source/levels/intermediate/connect_lightning_components.rst
Outdated
Show resolved
Hide resolved
docs/source/api_reference/api/lightning_app.core.LightningFlow.rst
Outdated
Show resolved
Hide resolved
docs/source/api_reference/api/lightning_app.core.LightningWork.rst
Outdated
Show resolved
Hide resolved
@awaelchli, all good catches, and sorry I missed then... :( UPDATE: redone the whole PR from ground paying proper attention to it 😇 |
7e8b443
to
7a00e8a
Compare
the true check is in: https://github.com/Lightning-AI/lightning/actions/runs/4149219807 |
@@ -1,10 +0,0 @@ | |||
.. role:: hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't find this, where was it moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed as it duplicated the generated on and caused an issue while building docs, in fact, that shall be removed a while back as this was a bad artifact...
|
||
- repo: https://github.com/psf/black | ||
rev: 22.12.0 | ||
hooks: | ||
- id: black | ||
name: Format code | ||
exclude: docs/source-app | ||
exclude: docs/source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended? Do we not want to just include the app files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunalyly it is inted and it was explicitly asked by @williamFalcon as he was not happy about formating docs...
cc: @justusschock
What does this PR do?
seems the deploy was failing bease we have not generated
lightning_app
in fact, we shall be changing all imports in unified docs to
lightning
insteadBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca @akihironitta @justusschock @awaelchli