[App] Enable uploading files to a project. #16631

tchaton · 2023-02-03T19:02:16Z

What does this PR do?

This PR enables uploading files to across a project using the new API.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

…tning into resolve_cp_bug

github-actions · 2023-02-03T19:38:30Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py, tests/tests_app/cli/test_cp.py, tests/tests_app/storage/test_filesystem.py, requirements/app/base.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py, requirements/app/base.txt.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py, requirements/app/base.txt.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py, requirements/app/base.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/base.txt, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/storage/filesystem.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/network.py, requirements/app/base.txt.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

…om/Lightning-AI/lightning into add_upload_delete_at_project_level

* update * update * update * update * update * update * update * update * update * update * update * update * update * update --------- Co-authored-by: thomas <[email protected]> (cherry picked from commit 55a0caa)

thomas and others added 7 commits February 3, 2023 15:19

update

5073a1c

update

3365380

Merge branch 'master' into resolve_cp_bug

b8ee6b0

update

726a5ce

Merge branch 'resolve_cp_bug' of https://github.com/Lightning-AI/ligh…

4be5e67

…tning into resolve_cp_bug

update

dac2271

update

cff685b

github-actions bot added the app (removed) Generic label for Lightning App package label Feb 3, 2023

update

f019a0e

tchaton marked this pull request as ready for review February 3, 2023 19:38

tchaton requested review from lantiga, awaelchli, hhsecond and ethanwharris as code owners February 3, 2023 19:38

update

fbe9a0a

tchaton self-assigned this Feb 3, 2023

tchaton and others added 3 commits February 4, 2023 09:21

Merge branch 'master' into add_upload_delete_at_project_level

b31c0f6

update

dac130c

Merge branch 'add_upload_delete_at_project_level' of https://github.c…

076931e

…om/Lightning-AI/lightning into add_upload_delete_at_project_level

tchaton requested a review from Borda as a code owner February 4, 2023 15:48

thomas and others added 8 commits February 4, 2023 15:52

update

3f5683b

update

277d492

update

96ee52a

Merge branch 'master' into add_upload_delete_at_project_level

e1365e5

update

09610bd

Merge branch 'add_upload_delete_at_project_level' of https://github.c…

c0e26c3

…om/Lightning-AI/lightning into add_upload_delete_at_project_level

update

b56b126

update

c3a0953

williamFalcon merged commit 55a0caa into master Feb 5, 2023

williamFalcon deleted the add_upload_delete_at_project_level branch February 5, 2023 11:35

awaelchli added this to the v1.9.x milestone Feb 10, 2023

akihironitta mentioned this pull request Feb 10, 2023

[App] Revert raising error from LightningClient on 500 #16723

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App] Enable uploading files to a project. #16631

[App] Enable uploading files to a project. #16631

tchaton commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

[App] Enable uploading files to a project. #16631

[App] Enable uploading files to a project. #16631

Conversation

tchaton commented Feb 3, 2023 • edited Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

github-actions bot commented Feb 3, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

tchaton commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading