-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App] Fix app name in URL #16575
Merged
Merged
[App] Fix app name in URL #16575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
added
bug
Something isn't working
app (removed)
Generic label for Lightning App package
app:cli
labels
Jan 31, 2023
ethanwharris
requested review from
tchaton,
lantiga,
awaelchli and
hhsecond
as code owners
January 31, 2023 11:24
yurijmikhalevich
approved these changes
Jan 31, 2023
Borda
pushed a commit
that referenced
this pull request
Feb 9, 2023
(cherry picked from commit 3001c7c)
lantiga
pushed a commit
that referenced
this pull request
Feb 10, 2023
(cherry picked from commit 3001c7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes the instance name can be
undefined
for older apps.This PR uses the name directly rather than taking it from the instance.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃