Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1656

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Update docs #1656

merged 4 commits into from
Apr 29, 2020

Conversation

cmpute
Copy link
Contributor

@cmpute cmpute commented Apr 29, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

@mergify mergify bot requested a review from a team April 29, 2020 02:00
docs/source/slurm.rst Outdated Show resolved Hide resolved
docs/source/fast_training.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update. I like the compactness :)
Btw, I make these also doctest in #1511 . I should get back to it soon :)

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1656 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1656   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          71      71           
  Lines        4175    4175           
======================================
  Hits         3691    3691           
  Misses        484     484           

@Borda Borda added the docs Documentation related label Apr 29, 2020
@Borda Borda requested a review from a team April 29, 2020 10:41
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦝

@Borda Borda requested a review from a team April 29, 2020 11:39
@Borda Borda added this to the 0.7.6 milestone Apr 29, 2020
@Borda Borda added the ready PRs ready to be merged label Apr 29, 2020
Copy link
Contributor

@tullie tullie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. LGTM

@mergify mergify bot merged commit 9b86aea into Lightning-AI:master Apr 29, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2020

Great job! =)

@cmpute cmpute deleted the doc branch July 9, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants