New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Add `lightning open` command #16482

Merged

ethanwharris merged 10 commits into master from feature/lightning_open

Jan 24, 2023

Member

ethanwharris commented Jan 23, 2023 •

edited by github-actions bot

Loading

What does this PR do?

Adds the lightning open command (early access, not currently enabled for all users)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃


          [App] Add lightning open command

af75d2a

ethanwharris added app (removed) app:cli labels

ethanwharris added this to the v1.9.x milestone

ethanwharris self-assigned this

ethanwharris requested review from tchaton, lantiga, awaelchli and hhsecond as code owners

January 23, 2023 23:01

Contributor

github-actions bot commented Jan 23, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, tests/tests_app/runners/test_cloud.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/cli/lightning_cli.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

ethanwharris added 5 commits

January 23, 2023 23:07

Fix

730b3ab


          Merge branch 'master' into feature/lightning_open

327b572


          Fixes

de59ef4


          Merge branch 'feature/lightning_open' of github.com:Lightning-AI/ligh…

b4af62d

…tning into feature/lightning_open


          Fixes

3bf677b

tchaton reviewed

View reviewed changes

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved

src/lightning_app/runners/cloud.py Show resolved Hide resolved

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved

src/lightning_app/runners/cloud.py Show resolved Hide resolved

src/lightning_app/runners/cloud.py Show resolved Hide resolved

tchaton reviewed

View reviewed changes

src/lightning_app/runners/cloud.py Show resolved Hide resolved

src/lightning_app/runners/cloud.py Show resolved Hide resolved

ethanwharris added 2 commits

January 24, 2023 12:41


          Switch for print


          Add warning on reopen and test

34c8a7b

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM !


          Add comment

3cc4735

rlizzo suggested changes

View reviewed changes

Contributor

rlizzo left a comment

a few questions and comments here. mostly documentation and user output related. code looks good

src/lightning_app/cli/lightning_cli.py Outdated Show resolved Hide resolved

src/lightning_app/cli/lightning_cli.py Outdated Show resolved Hide resolved

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved

src/lightning_app/runners/cloud.py Outdated Show resolved Hide resolved


          Update in response to review

c5aaa1b

rlizzo approved these changes

View reviewed changes

Contributor

rlizzo left a comment

Looks great! Thanks for the comment updates!

mergify bot added the ready label

ethanwharris merged commit 4a802e0 into master

ethanwharris deleted the feature/lightning_open branch

January 24, 2023 15:58

Borda pushed a commit that referenced this pull request


          [App] Add lightning open command (#16482)

34fafcb

(cherry picked from commit 4a802e0)

lantiga pushed a commit that referenced this pull request


          [App] Add lightning open command (#16482)

e0f84be

(cherry picked from commit 4a802e0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rlizzo rlizzo approved these changes

tchaton tchaton approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

awaelchli Awaiting requested review from awaelchli

hhsecond Awaiting requested review from hhsecond

Labels

app (removed) ready