[App] Add interruptible work #16399

tchaton · 2023-01-17T12:08:46Z

What does this PR do?

This PR introduces preemtible GPU using direct ec2 driver on the platform.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

for more information, see https://pre-commit.ci

…htning into add_preemptible

github-actions · 2023-01-24T14:18:28Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py, tests/tests_app/core/test_constants.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/core/test_lightning_work.py, tests/tests_app/core/test_queues.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/structures/test_structures.py, tests/tests_app/utilities/packaging/test_cloud_compute.py, tests/tests_app/utilities/test_load_app.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py, examples/app_interruptible/app.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/network.py, src/lightning_app/utilities/packaging/cloud_compute.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning_app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

examples/app_preemptible/.lightningignore

src/lightning_app/core/constants.py

src/lightning_app/utilities/packaging/cloud_compute.py

tests/tests_app/utilities/packaging/test_cloud_compute.py

ethanwharris

LGTM 😃

src/lightning_app/utilities/packaging/cloud_compute.py

src/lightning_app/utilities/network.py

src/lightning_app/core/queues.py

tests/tests_app/core/test_constants.py

src/lightning_app/core/constants.py

…htning into add_preemptible

Co-authored-by: thomas <[email protected]> Co-authored-by: Your Name <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit b8eaabe)

update

3603ed8

github-actions bot added the app (removed) Generic label for Lightning App package label Jan 17, 2023

thomas and others added 11 commits January 18, 2023 10:39

update

9e5b8dd

update

b524f49

[pre-commit.ci] auto fixes from pre-commit.com hooks

d1b875e

for more information, see https://pre-commit.ci

update

44def70

Merge branch 'add_preemptible' of https://github.com/Lightning-AI/lig…

ec97864

…htning into add_preemptible

update

b94ce6e

update

db62d63

update

88217a9

update

fd0e4da

update

3ac47a8

update

bb9223c

tchaton self-assigned this Jan 24, 2023

tchaton modified the milestones: 2.0, future Jan 24, 2023

tchaton added the feature Is an improvement or enhancement label Jan 24, 2023

thomas added 2 commits January 24, 2023 14:08

update

0b92572

update

75a16d8

tchaton marked this pull request as ready for review January 24, 2023 14:17

tchaton requested review from lantiga, awaelchli, hhsecond and ethanwharris as code owners January 24, 2023 14:17

tchaton changed the title ~~Add preemptible work~~ [App] Add preemptible work Jan 24, 2023

update

e494ca2

ethanwharris reviewed Jan 24, 2023

View reviewed changes

update

6825fb6

tchaton requested a review from ethanwharris January 24, 2023 16:40

ethanwharris approved these changes Jan 24, 2023

View reviewed changes

awaelchli approved these changes Jan 24, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jan 24, 2023

thomas and others added 4 commits January 24, 2023 18:33

update

634ab46

update

081f80c

update

864360b

Merge branch 'master' into add_preemptible

1a3a18d

tchaton changed the title ~~[App] Add preemptible work~~ [App] Add interruptible work Jan 25, 2023

thomas and others added 9 commits January 25, 2023 09:46

update

ce002fd

update

4abd52c

Merge branch 'master' into add_preemptible

4ac1c3d

update

6bafd2e

Merge branch 'add_preemptible' of https://github.com/Lightning-AI/lig…

b0dfd1f

…htning into add_preemptible

update

6df12ae

update

ee59bc1

update

1848c61

Merge branch 'master' into add_preemptible

e1ad144

tchaton enabled auto-merge (squash) January 25, 2023 11:07

thomas added 4 commits January 25, 2023 12:06

update

5443001

Merge branch 'add_preemptible' of https://github.com/Lightning-AI/lig…

e8c69ac

…htning into add_preemptible

update

c881b85

update

ed08267

tchaton merged commit b8eaabe into master Jan 25, 2023

tchaton deleted the add_preemptible branch January 25, 2023 13:48

carmocca modified the milestones: future, v1.9.x Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App] Add interruptible work #16399

[App] Add interruptible work #16399

tchaton commented Jan 17, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 24, 2023 •

edited

Loading

ethanwharris left a comment

[App] Add interruptible work #16399

[App] Add interruptible work #16399

Conversation

tchaton commented Jan 17, 2023 • edited by github-actions bot Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

github-actions bot commented Jan 24, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

ethanwharris left a comment

Choose a reason for hiding this comment

tchaton commented Jan 17, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 24, 2023 •

edited

Loading