move `tensorboardX` to extra #16349

Borda · 2023-01-12T18:03:17Z

What does this PR do?

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock

github-actions · 2023-01-13T13:51:52Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info.

🔴 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	failure	❌

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, docs/source-pytorch/common/trainer.rst, docs/source-pytorch/conf.py, docs/source-pytorch/extensions/logging.rst, docs/source-pytorch/starter/introduction.rst, docs/source-pytorch/visualize/logging_basic.rst, docs/source-pytorch/visualize/supported_exp_managers.rst, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	success	✅
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to .github/workflows/ci-pkg-install.yml, src/pytorch_lightning/loggers/tensorboard.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, requirements/pytorch/base.txt, requirements/pytorch/extra.txt, requirements/pytorch/loggers.info.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

requirements/pytorch/extra.txt

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

src/pytorch_lightning/trainer/trainer.py

src/pytorch_lightning/CHANGELOG.md

lantiga

Tweaked the error message, I hope it provides more context while being easy to understand.

src/pytorch_lightning/trainer/trainer.py

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

carmocca

I updated the docs

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Luca Antiga <[email protected]>

…g/pytorch-lightning into req/tensorboardX

docs/source-pytorch/extensions/logging.rst

docs/source-pytorch/visualize/supported_exp_managers.rst

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py

Co-authored-by: Carlos Mocholí <[email protected]>

Borda and others added 2 commits January 12, 2023 19:02

tensorboardX > extra

d3325ec

Merge branch 'master' into req/tensorboardX

1333ad5

github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 12, 2023

Borda added 3 commits January 13, 2023 14:34

Merge branch 'master' into req/tensorboardX

7b42554

default

3fda9fe

chlog

8af9932

Borda marked this pull request as ready for review January 13, 2023 13:50

Borda requested review from williamFalcon, tchaton, awaelchli, carmocca and justusschock as code owners January 13, 2023 13:50

Borda requested review from lantiga and a team January 13, 2023 13:54

Borda added the breaking change Includes a breaking change label Jan 13, 2023

Borda added this to the v1.9 milestone Jan 13, 2023

Borda added 2 commits January 13, 2023 15:01

doctest_skip

3c7285f

mypy

274345d

carmocca reviewed Jan 13, 2023

View reviewed changes

lantiga approved these changes Jan 13, 2023

View reviewed changes

src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Outdated Show resolved Hide resolved

Update docs

a5ab1bd

carmocca requested a review from edenlightning as a code owner January 13, 2023 14:35

plus

b0b6fc0

carmocca reviewed Jan 13, 2023

View reviewed changes

src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py Outdated Show resolved Hide resolved

Borda and others added 3 commits January 13, 2023 15:40

Apply suggestions from code review

0f4debd

Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Luca Antiga <[email protected]>

Merge branch 'req/tensorboardX' of https://github.com/PyTorchLightnin…

69eac25

…g/pytorch-lightning into req/tensorboardX

fix

946a76a

Borda requested a review from akihironitta as a code owner January 13, 2023 14:42

Borda requested a review from carmocca January 13, 2023 14:48

Borda added 2 commits January 13, 2023 15:52

mypy

c9e8566

docs

a6b3c83

carmocca approved these changes Jan 13, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jan 13, 2023

Borda and others added 4 commits January 13, 2023 17:30

Apply suggestions from code review

38141a3

Co-authored-by: Carlos Mocholí <[email protected]>

.

7b1100a

ll

67a83bd

Merge branch 'master' into req/tensorboardX

a783270

lantiga approved these changes Jan 16, 2023

View reviewed changes

lantiga merged commit 13c3136 into master Jan 16, 2023

lantiga deleted the req/tensorboardX branch January 16, 2023 08:06

JacobHayes mentioned this pull request Jan 19, 2023

Make tensorboard into an pip extra #9900

Closed

adamjstewart mentioned this pull request Apr 1, 2023

Deps: make omegaconf/tensorboard optional microsoft/torchgeo#1214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move `tensorboardX` to extra #16349

move `tensorboardX` to extra #16349

Borda commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading

lantiga left a comment

carmocca left a comment

move tensorboardX to extra #16349

move tensorboardX to extra #16349

Conversation

Borda commented Jan 12, 2023 • edited Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

github-actions bot commented Jan 13, 2023 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

lantiga left a comment

Choose a reason for hiding this comment

carmocca left a comment

Choose a reason for hiding this comment

move `tensorboardX` to extra #16349

move `tensorboardX` to extra #16349

Borda commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading