Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "finished" status code in MLFlowLogger #16340

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Fix "finished" status code in MLFlowLogger #16340

merged 5 commits into from
Jan 12, 2023

Conversation

Forbu
Copy link
Contributor

@Forbu Forbu commented Jan 11, 2023

What does this PR do?

A very simple modification of the MLFlowLogger class to handle the slurm plugin.

Fixes #16332

Does your PR introduce any breaking changes?

Minimal change.
MLflow accept ['RUNNING', 'SCHEDULED', 'FINISHED', 'FAILED', 'KILLED'] as a list a status so nothing can break here.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃
Well looking at lightning code was fun ^^ it is my first real pull request on an open source repo :) (although very simple PR).

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 11, 2023
@awaelchli awaelchli changed the title Fixes #16332 (slurm plugin - mlflow logger compatibility) Fix "finished" status code in MLFlowLogger Jan 11, 2023
@awaelchli awaelchli added bug Something isn't working logger: mlflow community This PR is from the community labels Jan 11, 2023
@awaelchli awaelchli self-assigned this Jan 11, 2023
@awaelchli awaelchli added this to the v1.9 milestone Jan 11, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @Forbu

@mergify mergify bot added the ready PRs ready to be merged label Jan 12, 2023
@awaelchli awaelchli enabled auto-merge (squash) January 12, 2023 14:49
@awaelchli awaelchli merged commit 898a236 into Lightning-AI:master Jan 12, 2023
nicolai86 pushed a commit that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community logger: mlflow pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLURM signal and mlflow logger not compatible
3 participants