[App] Fix env variable login #16339
Merged
[App] Fix env variable login #16339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
added
app (removed)
ethanwharris
requested review from
tchaton,
lantiga,
awaelchli and
hhsecond
as code owners
for more information, see https://pre-commit.ci
awaelchli
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
@ethanwharris FYI, with the changes in src/lightning_app/utilities/login.py undone, the tests in login.py still pass.
I did:
gh pr checkout 16339
git checkout master src/lightning_app/utilities/login.py
py.test -v tests/tests_app/utilities/test_login.py
|
Thanks @awaelchli !!! I've updated the tests to actually check for the credentials file and also refactored the Auth class a bit further to do all authentication in one place. Mind re-reviewing? |
Borda
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where login with env variables from the CLI would pass but then not actually create the credentials file.
This is because the CLI login calls
auth = Auth(); auth.clear()and we were using__post_init__to process the environment variables and save the credential file which would then be immediately deleted by the clear call.No added tests, but added calls to
auth.clearso the tests reflect the CLI command.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda