Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the HorovodStrategy #16141

Merged
merged 6 commits into from
Dec 20, 2022
Merged

Deprecate the HorovodStrategy #16141

merged 6 commits into from
Dec 20, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 20, 2022

What does this PR do?

Closes #12065
Closes #10863
Closes #13665
Closes #11975

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @awaelchli

@carmocca carmocca added deprecation Includes a deprecation strategy: horovod (removed) pl Generic label for PyTorch Lightning package labels Dec 20, 2022
@carmocca carmocca added this to the v1.9 milestone Dec 20, 2022
@carmocca carmocca self-assigned this Dec 20, 2022
@carmocca carmocca marked this pull request as ready for review December 20, 2022 16:47
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success
pl-cpu (macOS-11, lightning, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.13) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/data/horovod/train_default_model.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/data/horovod/train_default_model.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/data/horovod/train_default_model.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/data/horovod/train_default_model.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py, docs/source-pytorch/accelerators/gpu_faq.rst, docs/source-pytorch/accelerators/gpu_intermediate.rst, docs/source-pytorch/api_references.rst, docs/source-pytorch/common/trainer.rst, docs/source-pytorch/extensions/strategy.rst, docs/source-pytorch/starter/lightning_lite.rst.

🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success
lite-cpu (macOS-11, lite, 3.9, 1.12) success
lite-cpu (macOS-11, lite, 3.10, 1.13) success
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest) success
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest) success
lite-cpu (windows-2022, lite, 3.9, 1.11) success
lite-cpu (windows-2022, lite, 3.10, 1.12) success
lite-cpu (windows-2022, lite, 3.10, 1.13) success
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest) success
lite-cpu (macOS-11, lightning, 3.8, 1.13) success
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
lite-cpu (windows-2022, lightning, 3.8, 1.13) success

These checks are required after the changes to tests/tests_lite/conftest.py.

🟢 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) success

These checks are required after the changes to tests/tests_lite/conftest.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, lite, 3.7) success
install-pkg (ubuntu-22.04, lite, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, lite, 3.7) success
install-pkg (macOS-12, lite, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, lite, 3.7) success
install-pkg (windows-2022, lite, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/pytorch_lightning/strategies/horovod.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/imports.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca enabled auto-merge (squash) December 20, 2022 17:24
@carmocca carmocca merged commit bf8e568 into master Dec 20, 2022
@carmocca carmocca deleted the deprecation/horovod branch December 20, 2022 17:38
@mergify mergify bot added the ready PRs ready to be merged label Dec 20, 2022
carmocca added a commit that referenced this pull request Dec 20, 2022
carmocca added a commit that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: horovod (removed)
Projects
None yet
3 participants