Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Resolve some bugs from the Training Studio scaling #16114

Merged
merged 40 commits into from
Dec 19, 2022
Merged

[App] Resolve some bugs from the Training Studio scaling #16114

merged 40 commits into from
Dec 19, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 19, 2022 •
edited by github-actions bot
Loading

What does this PR do?

This PR resolves couple of issues found during Training Studio development:

  • The flow doesn't exit early if no delta is found
  • STATE_ACCUMULATE_WAIT was slightly too low to get enough delta
  • The Http Queue would wait HTTP_QUEUE_REFRESH_INTERVAL=1 sec
  • Root_path check wasn't placed at the right place
  • Non Thread-safe operation with deepcopy within the scheduler
  • shm_size should be 1024 when the name contains gpu.

This PR can be split in pieces if requested by reviewers.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton marked this pull request as draft December 19, 2022 15:15
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Dec 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, tests/tests_app/components/serve/test_model_inference_api.py, tests/tests_app/components/serve/test_python_server.py, tests/tests_app/conftest.py, tests/tests_app/core/test_lightning_api.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/core/test_lightning_work.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/utilities/packaging/test_cloud_compute.py, tests/tests_app/utilities/test_commands.py, tests/tests_app/utilities/test_git.py, tests/tests_app/utilities/test_load_app.py, tests/tests_app/utilities/test_proxies.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/queues.py, src/lightning_app/runners/cloud.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/frontend.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@tchaton tchaton self-assigned this Dec 19, 2022
@tchaton tchaton added the bug Something isn't working label Dec 19, 2022
@tchaton tchaton marked this pull request as ready for review December 19, 2022 17:21
awaelchli
awaelchli approved these changes Dec 19, 2022
View reviewed changes
src/lightning_app/utilities/frontend.py Show resolved Hide resolved
src/lightning_app/runners/cloud.py Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) December 19, 2022 18:56
ethanwharris
ethanwharris approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

lantiga
lantiga reviewed Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm uncomfortable with us looping a request towards a server without pausing

src/lightning_app/core/queues.py Show resolved Hide resolved
@tchaton tchaton merged commit 51ec949 into master Dec 19, 2022
@tchaton tchaton deleted the resolve_bugs branch December 19, 2022 23:12
carmocca pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @carmocca
[App] Resolve some bugs from the Training Studio scaling (#16114)
f3b3a3b 
Co-authored-by: thomas <[email protected]>
carmocca pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @carmocca
[App] Resolve some bugs from the Training Studio scaling (#16114)
ac3cda2 
Co-authored-by: thomas <[email protected]>
Borda pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @Borda
[App] Resolve some bugs from the Training Studio scaling (#16114)
2710b4d 
Co-authored-by: thomas <[email protected]>
(cherry picked from commit 51ec949)
carmocca pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @carmocca
[App] Resolve some bugs from the Training Studio scaling (#16114)
2b7b9bc 
Co-authored-by: thomas <[email protected]>
carmocca pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @carmocca
[App] Resolve some bugs from the Training Studio scaling (#16114)
3815445 
Co-authored-by: thomas <[email protected]>
carmocca pushed a commit that referenced this pull request Dec 20, 2022
@tchaton @carmocca
[App] Resolve some bugs from the Training Studio scaling (#16114)
42c0884 
Co-authored-by: thomas <[email protected]>
lantiga pushed a commit that referenced this pull request Dec 21, 2022
@Borda @tchaton
@carmocca @justusschock @awaelchli @akihironitta @ethanwharris @dependabot @mauvilsa
Releasing: 1.8.6 (#16134)
bffdc2f 
* chlog continued

* [App] PoC: Add support for Request (#16047)

(cherry picked from commit 592b126)

* Have checkgroup pull the latest runs (#16033)

(cherry picked from commit 4c91dec)

* Update Multinode Warning (#16091)

(cherry picked from commit 3d509f6)

* [App] Serve datatypes with better client code (#16018)

(cherry picked from commit 23013be)

* docs: add PT version (#16010)

* docs: add PT version

* stable

Co-authored-by: Adrian Wälchli <[email protected]>

Co-authored-by: Adrian Wälchli <[email protected]>
(cherry picked from commit c8b4bce)

* add 1.13.1 to adjust versions (#16099)

(cherry picked from commit acd48d3)

* [App] Add display name property to the work (#16095)

Co-authored-by: thomas <[email protected]>
(cherry picked from commit 22b254f)

* Fix detection of whether app is running in cloud (#16045)

(cherry picked from commit e54f4f5)

* [App] Add work.delete (#16103)

Co-authored-by: thomas <[email protected]>
(cherry picked from commit 80b7faf)

* [App] Improve the autoscaler UI (#16063)

[App] Improve the autoscaler UI (#16063)

(cherry picked from commit 39d27f6)

* [App] Min replica=0 would break autoscaler component (#16092)

* fixing the bug where num_replica=0 would fail

* changelog

(cherry picked from commit aba5f12)

* [App] Scale out/in interval for autoscaler (#16093)

* Adding arguments for scale out/in interval

* Tests

(cherry picked from commit 0fd3d54)

* Set the default work start method to spawn on MacOS (#16089)

(cherry picked from commit f3157f3)

* [App] Add status endpoint, enable `ready` (#16075)

Co-authored-by: thomas chaton <[email protected]>
(cherry picked from commit 2a85d9b)

* Clarify `work.stop()` limitation (#16073)

(cherry picked from commit 0abd686)

* Update torchvision requirement from <=0.14.0,>=0.11.1 to >=0.11.1,<0.15.0 in /requirements (#16108)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>

(cherry picked from commit e8ac9e9)

* CI: settle file names (#16098)

* CI: settle file names

* rename

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit a203b04)

* [App] Resolve some bugs from the Training Studio scaling (#16114)

Co-authored-by: thomas <[email protected]>
(cherry picked from commit 51ec949)

* Update scikit-learn requirement from <1.1.3,>0.22.1 to >0.22.1,<1.2.1 in /requirements (#16107)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit d070e72)

* [App] update app testing (#16000)

Co-authored-by: thomas <[email protected]>
(cherry picked from commit 8b68e20)

* [App] Change overwrite to True (#16009)

Co-authored-by: thomas <[email protected]>
(cherry picked from commit 085c6b3)

* [App] Improve PythonServer info message on startup (#15989)

* change msg
* update chgl
* show the user's class name

(cherry picked from commit 848ea56)

* [App] Cold start proxy in autoscaler (#16094)

* cold start proxy

* Update src/lightning_app/components/serve/auto_scaler.py

* changelog

* better-doc

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit 7cbdc68)

* Fix endpoint information tab not showing up in AutoScaler UI (#16128)

* .

* why

* Revert "why"

This reverts commit 375d3e8.

* tried api access with fixed values

* Revert "tried api access with fixed values"

This reverts commit f1720f6.

* Fix typo 🎉

* update chglog

* revert removing lines in chlog

* update chglog

Co-authored-by: Akihiro Nitta <[email protected]>
(cherry picked from commit 7b275bc)

* [App] Implement `ready` for components (#16129)

(cherry picked from commit 711aec5)

* [App] Fix e2e tests (#16146)

(cherry picked from commit c98b0c4)

* [App] Remove outdated warning from cloud requirements (#16140)

(cherry picked from commit bf5fa35)

* [App] Fix support for streamlit > 1.14 (#16139)

(cherry picked from commit ec336bc)

* Fix broken link in "Build a Model" section of docs (#16025)

fix build model link

(cherry picked from commit 1c02288)

* drop colossalai from testing as no stable release yet (#16122)

(cherry picked from commit 1e16836)

* [App] Simplify messaging in cloud dispatch (#16160)

(cherry picked from commit 9657671)

* [App] Add annotations endpoint (#16159)

(cherry picked from commit 0630444)

* Small fix in test_cli.py to avoid failure with future version of jsonargparse (#16156)

(cherry picked from commit 50331e0)

* Fix test failing on master due to bad auto-merge (#16118)

(cherry picked from commit 07b775f)

* ver1.8.6

Co-authored-by: Sherin Thomas <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mauricio Villegas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga left review comments

@hhsecond hhsecond hhsecond approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaton @lantiga @awaelchli @ethanwharris @hhsecond