Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LightningModule support for Lite #16048

Merged
merged 45 commits into from
Dec 16, 2022
Merged

LightningModule support for Lite #16048

merged 45 commits into from
Dec 16, 2022

Conversation

lightningforever
Copy link
Contributor

@lightningforever lightningforever commented Dec 14, 2022 •
edited
Loading

What does this PR do?

Adds a LightningModule integration for Lite.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 14, 2022
@lightningforever lightningforever marked this pull request as ready for review December 15, 2022 09:06
@lightningforever lightningforever marked this pull request as draft December 15, 2022 09:07
@lightningforever lightningforever marked this pull request as ready for review December 16, 2022 09:50
@awaelchli awaelchli requested a review from carmocca December 16, 2022 12:39
lantiga
lantiga approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this ❤️!!!

@mergify mergify bot added the ready PRs ready to be merged label Dec 16, 2022
@awaelchli awaelchli enabled auto-merge (squash) December 16, 2022 14:08
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 16, 2022
@awaelchli awaelchli merged commit 0fc7b82 into Lightning-AI:lite/debug Dec 16, 2022
@lightningforever lightningforever deleted the lite/debug-lm branch December 16, 2022 15:59
carmocca pushed a commit that referenced this pull request Jan 4, 2023
@lightningforever @carmocca
LightningModule support for Lite (#16048)
4891075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@lantiga lantiga lantiga approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lightningforever @lantiga @awaelchli @carmocca @justusschock