Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for logging in different trainer stages #16002

Merged
merged 13 commits into from
Jan 9, 2023

Conversation

yMayanand
Copy link
Contributor

@yMayanand yMayanand commented Dec 10, 2022

added support for logging in different trainer stages with DeviceStatsMonitor

What does this PR do?

Fixes #15794

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 10, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Dec 11, 2022
@yMayanand yMayanand marked this pull request as ready for review December 11, 2022 08:23
@Borda Borda changed the title added support for logging in different trainer stages with DeviceStat… added support for logging in different trainer stages Dec 12, 2022
@Borda Borda added the feature Is an improvement or enhancement label Dec 12, 2022
@carmocca carmocca added callback: device stats pl Generic label for PyTorch Lightning package community This PR is from the community labels Dec 12, 2022
@carmocca carmocca added this to the v1.9 milestone Dec 12, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Dec 12, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 9, 2023
@awaelchli awaelchli merged commit d206ca3 into Lightning-AI:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: device stats community This PR is from the community feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for logging in different trainer stages with DeviceStatsMonitor
5 participants