-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for logging in different trainer stages #16002
Merged
awaelchli
merged 13 commits into
Lightning-AI:master
from
yMayanand:devicestats/diff_stages
Jan 9, 2023
Merged
added support for logging in different trainer stages #16002
awaelchli
merged 13 commits into
Lightning-AI:master
from
yMayanand:devicestats/diff_stages
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yMayanand
requested review from
tchaton,
lantiga,
awaelchli,
hhsecond,
ethanwharris,
carmocca,
justusschock and
williamFalcon
as code owners
December 11, 2022 08:23
Borda
changed the title
added support for logging in different trainer stages with DeviceStat…
added support for logging in different trainer stages
Dec 12, 2022
carmocca
reviewed
Dec 12, 2022
carmocca
added
callback: device stats
pl
Generic label for PyTorch Lightning package
community
This PR is from the community
labels
Dec 12, 2022
tchaton
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
approved these changes
Jan 9, 2023
awaelchli
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback: device stats
community
This PR is from the community
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for logging in different trainer stages with DeviceStatsMonitor
What does this PR do?
Fixes #15794
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃