Fix cloudcomputes registration for structures #15964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
justusschock
changed the title
awaelchli
changed the title
justusschock
requested review from
tchaton,
lantiga,
awaelchli,
hhsecond and
ethanwharris
as code owners
awaelchli
approved these changes
Dec 9, 2022
Borda
approved these changes
Dec 9, 2022
for more information, see https://pre-commit.ci
|
Failures in examples coming from #15965 not being merged yet :) |
Borda
pushed a commit
that referenced
this pull request
Dec 9, 2022
* fix cloudcomputes * updates cloudcompute registration * changelog (cherry picked from commit 90a4c02)
lantiga
added a commit
that referenced
this pull request
Dec 9, 2022
* Apply dynamo to training_step, validation_step, test_step, predict_step (#15957) * Apply dynamo to training_step, validation_step, test_step, predict_step * Add entry to CHANGELOG.md (cherry picked from commit edc9986) * [App] Resolve run installation (#15974) (cherry picked from commit dd83587) * App: Move AutoScaler dependency to extra requirements (#15971) * Make autoscaler dependency optional * update chglog * dont directly import aiohttp (cherry picked from commit 346e936) # Conflicts: # requirements/app/base.txt # src/lightning_app/CHANGELOG.md * Avoid using the same port number for autoscaler works (#15966) * dont hardcode port in python server * add another chglog (cherry picked from commit a72d268) * Fix `action_name` usage in `XLAProfiler` (#15886) * Fix `action_name` usage in `XLAProfiler` * add changelog * Update src/pytorch_ligh * Update xla.py Co-authored-by: awaelchli <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit c748f82) * Fix multinode cloud component (#15965) * fix multinode cloud component * add tests (cherry picked from commit d21b899) * ci: update signaling (#15981) * ci: update signaling * config (cherry picked from commit e56e7f1) * Fix cloudcomputes registration for structures (#15964) * fix cloudcomputes * updates cloudcompute registration * changelog (cherry picked from commit 90a4c02) * Document running dev lightning on the cloud (#15962) * document running dev lightning on the cloud * document running dev lightning on the cloud * Update .github/CONTRIBUTING.md Co-authored-by: Noha Alon <[email protected]> * document running dev lightning on the cloud * git clone & pip install -e * Update .github/CONTRIBUTING.md Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Noha Alon <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit cfd00d3) * [App] Install exact version whn upgrading and not when testing (#15984) * [App] Install exact version whn upgrading and not when testing * Update CHANGELOG.md Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 1657ea8) * releasing 1.8.4.post0 Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: thomas chaton <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Liyang90 <[email protected]> Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Ethan Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently Cloud Computes are not registered from structures directly, causing components such as
MultiNodeto bypass the check for unique cloudcompute ids. This PR will always call the registration and thereby the check mechanism.This will break MultiNode until #15965 is merged and therefore needs to be merged after #15965.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda