Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lite: Flatten XLAStrategy #15838

Merged
merged 5 commits into from
Dec 9, 2022
Merged

Lite: Flatten XLAStrategy #15838

merged 5 commits into from
Dec 9, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 27, 2022 •
edited by github-actions bot
Loading

What does this PR do?

The XLAStrategy now inherits from ParallelStrategy instead of DDPSpawnStrategy.
As you can see, the code changes are minimal, indicating that XLAStrategy has anyway already overridden most methods of the DDPSpawnStrategy.

Part of #14707
Part of #14952

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @JackCaoG @Liyang90 @gkroiz @justusschock @awaelchli @steventk-g

@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit refactor fabric lightning.fabric.Fabric strategy: ddp spawn fun Staff contributions outside working hours - to differentiate from the "community" label labels Nov 27, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 27, 2022
@awaelchli awaelchli mentioned this pull request Nov 27, 2022
Merged
11 tasks
@awaelchli awaelchli marked this pull request as ready for review December 7, 2022 02:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.10, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

These checks are required after the changes to src/lightning_lite/strategies/launchers/xla.py, src/lightning_lite/strategies/xla.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton
tchaton approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@JackCaoG
Copy link

JackCaoG commented Dec 9, 2022

@Liyang90

@awaelchli awaelchli merged commit 3c9b7cb into master Dec 9, 2022
@awaelchli awaelchli deleted the lite/flatten-xla-strategy branch December 9, 2022 22:27
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
accelerator: tpu Tensor Processing Unit fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@awaelchli @JackCaoG @tchaton @justusschock