Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axes argument to lr finder plot #15652

Merged
merged 4 commits into from
Nov 12, 2022

Conversation

bipinKrishnan
Copy link
Contributor

What does this PR do?

Fixes #15416

This adds an ax argument to trainer.tuner.lr_find().plot(), thus allowing users to provide an optional matplotlib Axes object for plotting the LR finder graph.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 11, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement community This PR is from the community tuner labels Nov 12, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 12, 2022
src/pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
@awaelchli awaelchli changed the title add axes argument to lr finder plot Add axes argument to lr finder plot Nov 12, 2022
src/pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) November 12, 2022 17:23
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 12, 2022
@carmocca carmocca merged commit aab8f48 into Lightning-AI:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions that plot should take an ax argument
3 participants