Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid torchelastic warning message when importing lightning #15610

Merged
merged 10 commits into from
Nov 10, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 9, 2022

What does this PR do?

When importing lightning_lite, pytorch_lightning, or lightning, we get the following warning:

NOTE: Redirects are currently not supported in Windows or MacOs

The message is confusing to the user. There is no action they can take to avoid it.

After this PR, only users that actually use the deepspeed strategy will see this warning.
We created an issue on DeepSpeed's GitHub: microsoft/DeepSpeed#2492

Part of #12786

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

@awaelchli awaelchli added bug Something isn't working 3rd party Related to a 3rd-party labels Nov 9, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 9, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 9, 2022
@awaelchli awaelchli self-assigned this Nov 9, 2022
@awaelchli awaelchli added the community This PR is from the community label Nov 9, 2022
@awaelchli awaelchli changed the title Avoid torchelastic info message when importing lightning Avoid torchelastic warning message when importing lightning Nov 9, 2022
@awaelchli awaelchli marked this pull request as ready for review November 9, 2022 22:36
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you !

@awaelchli awaelchli enabled auto-merge (squash) November 10, 2022 09:56
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 10, 2022
@awaelchli awaelchli merged commit 22813c4 into master Nov 10, 2022
@awaelchli awaelchli deleted the bugfix/avoid-deepspeed-torch-warning branch November 10, 2022 10:37
Borda pushed a commit that referenced this pull request Nov 10, 2022
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants