Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve component #15609

Merged
merged 30 commits into from
Nov 10, 2022
Merged

Serve component #15609

merged 30 commits into from
Nov 10, 2022

Conversation

hhsecond
Copy link
Contributor

@hhsecond hhsecond commented Nov 9, 2022

What does this PR do?

Introducing serve component. This allow users to pass the minimalistic things to serve their model under a work

class SimpleServer(L.app.components.serve.PythonServer):

    def setup(self):
        self._model = lambda x: x

    def predict(self, data):
        return self._model(data)


app = L.LightningApp(SimpleServer(port=7777))

Features missing are

  • Create a UI that exposes API information (using the APIAccessFrontend component)
  • Mulitple workers is out of scope

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 9, 2022
@hhsecond hhsecond marked this pull request as ready for review November 9, 2022 19:39
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hhsecond hhsecond self-assigned this Nov 9, 2022
@hhsecond hhsecond added this to the v1.8.x milestone Nov 9, 2022
@hhsecond hhsecond force-pushed the feature/serve-component branch from b0d217c to efd5125 Compare November 10, 2022 05:09
@hhsecond hhsecond requested a review from Borda as a code owner November 10, 2022 08:07
requirements/app/base.txt Outdated Show resolved Hide resolved
@hhsecond hhsecond requested a review from Borda November 10, 2022 09:08
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@hhsecond hhsecond merged commit f1bd68d into master Nov 10, 2022
@hhsecond hhsecond deleted the feature/serve-component branch November 10, 2022 10:01
@@ -13,3 +13,4 @@ beautifulsoup4<=4.8.2
inquirer>=2.10.0
psutil<5.9.4
click<=8.1.3
lightning_api_access>=0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replacement for lightning-cloud?

Borda pushed a commit that referenced this pull request Nov 10, 2022
Serve component (#15609)

(cherry picked from commit f1bd68d)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Serve component (#15609)

(cherry picked from commit f1bd68d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants