-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve component #15609
Serve component #15609
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
…htning into feature/serve-component
for more information, see https://pre-commit.ci
b0d217c
to
efd5125
Compare
for more information, see https://pre-commit.ci
…htning into feature/serve-component
for more information, see https://pre-commit.ci
…htning into feature/serve-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
@@ -13,3 +13,4 @@ beautifulsoup4<=4.8.2 | |||
inquirer>=2.10.0 | |||
psutil<5.9.4 | |||
click<=8.1.3 | |||
lightning_api_access>=0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this replacement for lightning-cloud
?
What does this PR do?
Introducing serve component. This allow users to pass the minimalistic things to serve their model under a work
Features missing are
APIAccessFrontend
component)Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda