[App] Add start_with_flow flag to works
#15591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
tchaton,
awaelchli,
hhsecond and
lantiga
as code owners
ethanwharris
changed the title
start_with_flow flag to worksstart_with_flow flag to works
awaelchli
approved these changes
Nov 9, 2022
Comment on lines
+142
to
+143
| if not work._start_with_flow: | ||
| continue |
There was a problem hiding this comment.
Wow! This must have changed recently. I didn't know we do this by default. That is definitely weird!
There was a problem hiding this comment.
The change hasn't happened yet but will soon, this is just in preparation 😃
Co-authored-by: Adrian Wälchli <[email protected]>
…AI/lightning into feature/works_startup
Borda
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Initial commit * Update cloud runner * Add `start_with_flow` flag * Update CHANGELOG.md * Update src/lightning_app/core/work.py Co-authored-by: Adrian Wälchli <[email protected]> * Update cloud runner * Revert, not needed Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 733695d)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Initial commit * Update cloud runner * Add `start_with_flow` flag * Update CHANGELOG.md * Update src/lightning_app/core/work.py Co-authored-by: Adrian Wälchli <[email protected]> * Update cloud runner * Revert, not needed Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 733695d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a flag which can be used to stop a work from starting at the same time as the flow
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃